Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2645473003: Merge M56:Trim AV names. (Closed)

Created:
3 years, 11 months ago by Will Harris
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge M56:Trim AV names. Correctly call trim function from antivirus metrics. BUG=615154 Review-Url: https://codereview.chromium.org/2635333002 Cr-Commit-Position: refs/heads/master@{#444182} (cherry picked from commit 1ce0d75da469537fd542b02ed0cf36bd9d95ecb7) Trim version and extraneus parts from AntiVirus product names. Some AV products include their version in the product name in WMI which makes maintaining the list of hashes of product names onerous. Therefore, trim anything that looks like a version, along with trailing spaces. BUG=615154 TEST=unit_tests --gtest_filter=AntiVirusMetricsProvider* Review-Url: https://codereview.chromium.org/2631583002 Cr-Commit-Position: refs/heads/master@{#443594} (cherry picked from commit da07d58a5d041395d3d6317ab3aef31c0087285e) Review-Url: https://codereview.chromium.org/2645473003 . Cr-Commit-Position: refs/branch-heads/2924@{#794} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/1cb5cebfa54152b226f9ec83589d79af4815c7da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -3 lines) Patch
M chrome/browser/metrics/antivirus_metrics_provider_win.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/metrics/antivirus_metrics_provider_win.cc View 6 chunks +35 lines, -3 lines 0 comments Download
M chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc View 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Will Harris
3 years, 11 months ago (2017-01-18 19:59:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1cb5cebfa54152b226f9ec83589d79af4815c7da.

Powered by Google App Engine
This is Rietveld 408576698