Merge M56:Trim AV names.

chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/antivirus_metrics_provider_win.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/run_loop.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "base/test/scoped_feature_list.h"
 #include "base/threading/thread_checker.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/version.h"
 #include "base/win/windows_version.h"
 #include "components/variations/metrics_util.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
+struct Testcase {
+  const char* input;
+  const char* output;
+};
+
 void VerifySystemProfileData(const metrics::SystemProfileProto& system_profile,
                              bool expect_unhashed_value) {
   const char kWindowsDefender[] = "Windows Defender";
 
   if (base::win::GetVersion() >= base::win::VERSION_WIN8) {
     bool defender_found = false;
     for (const auto& av : system_profile.antivirus_product()) {
       if (av.product_name_hash() == metrics::HashName(kWindowsDefender)) {
         defender_found = true;
         if (expect_unhashed_value) {
           EXPECT_TRUE(av.has_product_name());
           EXPECT_EQ(kWindowsDefender, av.product_name());
         } else {
           EXPECT_FALSE(av.has_product_name());
         }
         break;
       }
     }
     EXPECT_TRUE(defender_found);
   }
 }
 
 }  // namespace
 
+class AntiVirusMetricsProviderSimpleTest : public ::testing::Test {};
+
 class AntiVirusMetricsProviderTest : public ::testing::TestWithParam<bool> {
  public:
   AntiVirusMetricsProviderTest()
       : got_results_(false),
         expect_unhashed_value_(GetParam()),
         provider_(new AntiVirusMetricsProvider(
             content::BrowserThread::GetTaskRunnerForThread(
                 content::BrowserThread::FILE))),
         thread_bundle_(content::TestBrowserThreadBundle::REAL_FILE_THREAD),
         weak_ptr_factory_(this) {}
@@ skipping 61 matching lines @@
   AntiVirusMetricsProvider::ResultCode expected_result =
       AntiVirusMetricsProvider::RESULT_SUCCESS;
   if (base::win::OSInfo::GetInstance()->version_type() ==
       base::win::SUITE_SERVER)
     expected_result = AntiVirusMetricsProvider::RESULT_WSC_NOT_AVAILABLE;
   histograms.ExpectUniqueSample("UMA.AntiVirusMetricsProvider.Result",
                                 expected_result, 1);
 }
 
 INSTANTIATE_TEST_CASE_P(, AntiVirusMetricsProviderTest, ::testing::Bool());
+
+TEST_F(AntiVirusMetricsProviderSimpleTest, StripProductVersion) {
+  Testcase testcases[] = {
+      {"", ""},
+      {" ", ""},
+      {"1.0 AV 2.0", "1.0 AV"},
+      {"Anti  Virus", "Anti Virus"},
+      {"Windows Defender", "Windows Defender"},
+      {"McAfee AntiVirus has a space at the end ",
+       "McAfee AntiVirus has a space at the end"},
+      {"ESET NOD32 Antivirus 8.0", "ESET NOD32 Antivirus"},
+      {"Norton 360", "Norton 360"},
+      {"ESET Smart Security 9.0.381.1", "ESET Smart Security"},
+      {"Trustwave AV 3_0_2547", "Trustwave AV"},
+      {"nProtect Anti-Virus/Spyware V4.0", "nProtect Anti-Virus/Spyware"},
+      {"ESET NOD32 Antivirus 9.0.349.15P", "ESET NOD32 Antivirus"}};
+
+  for (const auto testcase : testcases) {
+    auto output =
+        AntiVirusMetricsProvider::TrimVersionOfAvProductName(testcase.input);
+    EXPECT_STREQ(testcase.output, output.c_str());
+  }
+}