Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

Issue 2645453002: Move EditCommand::starting/endingSelection() to CompositeEditCommand (2/2) (Closed)
Patch Set: Fix nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
index a8e51ac6720f6b80e1631ebe254d1332dde8038e..548d343f481a458468d60ede05fe5e191dc9865b 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
@@ -50,48 +50,6 @@ String EditCommand::textDataForInputEvent() const {
return nullAtom;
}
-// TODO(xiaochengh): Move it to CompositeEditCommand.cpp
-void CompositeEditCommand::setStartingSelection(
- const VisibleSelection& selection) {
- for (CompositeEditCommand* command = this;; command = command->parent()) {
- if (UndoStep* undoStep = command->undoStep()) {
- DCHECK(command->isTopLevelCommand());
- undoStep->setStartingSelection(selection);
- }
- command->m_startingSelection = selection;
- if (!command->parent() || command->parent()->isFirstCommand(command))
- break;
- }
-}
-
-// TODO(xiaochengh): Move it to CompositeEditCommand.cpp
-// TODO(yosin): We will make |SelectionInDOMTree| version of
-// |setEndingSelection()| as primary function instead of wrapper, once
-// |EditCommand| holds other than |VisibleSelection|.
-void CompositeEditCommand::setEndingSelection(
- const SelectionInDOMTree& selection) {
- // TODO(editing-dev): The use of
- // updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- document().updateStyleAndLayoutIgnorePendingStylesheets();
- setEndingVisibleSelection(createVisibleSelection(selection));
-}
-
-// TODO(xiaochengh): Move it to CompositeEditCommand.cpp
-// TODO(yosin): We will make |SelectionInDOMTree| version of
-// |setEndingSelection()| as primary function instead of wrapper.
-void CompositeEditCommand::setEndingVisibleSelection(
- const VisibleSelection& selection) {
- for (CompositeEditCommand* command = this; command;
- command = command->parent()) {
- if (UndoStep* undoStep = command->undoStep()) {
- DCHECK(command->isTopLevelCommand());
- undoStep->setEndingSelection(selection);
- }
- command->m_endingSelection = selection;
- }
-}
-
bool EditCommand::isRenderedCharacter(const Position& position) {
if (position.isNull())
return false;
@@ -114,15 +72,6 @@ void EditCommand::setParent(CompositeEditCommand* parent) {
m_parent = parent;
}
-// TODO(xiaochengh): Move it to CompositeEditCommand.cpp
-void CompositeEditCommand::setParent(CompositeEditCommand* parent) {
- EditCommand::setParent(parent);
- if (parent) {
- m_startingSelection = parent->m_endingSelection;
- m_endingSelection = parent->m_endingSelection;
- }
-}
-
void SimpleEditCommand::doReapply() {
EditingState editingState;
doApply(&editingState);
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698