Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 264543002: Revert 267095 "Remove WebUI NTP on Android." (Closed)

Created:
6 years, 7 months ago by falken
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 267095 "Remove WebUI NTP on Android." It may have caused Android Builder to fail: http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/38786/steps/compile/logs/stdio http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/56685/steps/compile/logs/stdio "error: undefined reference to 'NTPUserDataLogger::GetOrCreateFromWebContents(content::WebContents*)'" etc. > Remove WebUI NTP on Android. > > Chrome for Android has transitioned to using native NTP. This CL removes > the WebUI classes and resources. > > BUG=284770 > > Review URL: https://codereview.chromium.org/256763004 TBR=aurimas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, --5 lines) Patch
M trunk/src/chrome/app/bookmarks_strings.grdp View 2 chunks +14 lines, -0 lines 0 comments Download
M trunk/src/chrome/app/generated_resources.grd View 3 chunks +88 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/android/new_tab_page_prefs.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/prefs/browser_prefs.cc View 4 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/bookmarks.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/bookmarks_tablet.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_bg_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_bg_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_bg_tvdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_bg_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_border_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_border_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_border_tvdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_border_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_folder_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_folder_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_folder_tvdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/bookmark_folder_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/breadcrumb_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/breadcrumb_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/breadcrumb_tvdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/breadcrumb_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/default_thumbnail.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/disclosure_closed_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/disclosure_closed_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/disclosure_closed_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/disclosure_open_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/disclosure_open_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/disclosure_open_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/sent_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/sent_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/sent_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/syncfographic_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/syncfographic_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/syncfographic_sw600dp_hdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/syncfographic_sw600dp_mdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/syncfographic_sw600dp_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/syncfographic_xhdpi.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/images/welcome_thumb.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/incognito_tab.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/mockdata.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/mostvisited.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/mostvisited_tablet.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/new_tab.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/ntp_android.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/ntp_android.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/opentabs.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/resources/ntp_android/opentabs_tablet.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/search/instant_service.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/metrics_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/bookmarks_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/context_menu_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/context_menu_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/navigation_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/navigation_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/new_tab_page_ready_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/new_tab_page_ready_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/ntp_resource_cache_android.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/promo_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/webui/ntp/android/promo_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/ntp/most_visited_handler.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 chunk +8 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/ntp/new_tab_ui.cc View 5 chunks +60 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/ntp/ntp_resource_cache.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc View 4 chunks +23 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 4 chunks +27 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
falken
6 years, 7 months ago (2014-04-30 06:22:55 UTC) #1
falken
6 years, 7 months ago (2014-04-30 06:23:20 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r267100 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698