Remove WebUI NTP on Android.

Remove WebUI NTP on Android.

Chrome for Android has transitioned to using native NTP. This CL removes
the WebUI classes and resources.

BUG=284770
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267095

[aurimas (slooooooooow), 2014-04-25 18:37:12]

tedchoc: PTAL

[Ted C, 2014-04-25 19:50:57]

lgtm

https://chromiumcodereview.appspot.com/256763004/diff/1/chrome/browser/ui/web...
File chrome/browser/ui/webui/ntp/new_tab_ui.cc (right):

https://chromiumcodereview.appspot.com/256763004/diff/1/chrome/browser/ui/web...
chrome/browser/ui/webui/ntp/new_tab_ui.cc:234: bool NewTabUI::MightShowApps() {
I think you can remove this method entirely now

[aurimas (slooooooooow), 2014-04-25 20:10:47]

https://chromiumcodereview.appspot.com/256763004/diff/1/chrome/browser/ui/web...
File chrome/browser/ui/webui/ntp/new_tab_ui.cc (right):

https://chromiumcodereview.appspot.com/256763004/diff/1/chrome/browser/ui/web...
chrome/browser/ui/webui/ntp/new_tab_ui.cc:234: bool NewTabUI::MightShowApps() {
On 2014/04/25 19:50:58, Ted C wrote:
> I think you can remove this method entirely now

Done.

[aurimas (slooooooooow), 2014-04-25 20:13:00]

+thakis for chrome/browser/ review.
+isherman for tools/metrics/histograms/histograms.xml review.

[Nico, 2014-04-25 20:22:03]

lgtm

https://chromiumcodereview.appspot.com/256763004/diff/20001/chrome/browser/se...
File chrome/browser/search/instant_service.cc (right):

https://chromiumcodereview.appspot.com/256763004/diff/20001/chrome/browser/se...
chrome/browser/search/instant_service.cc:112: #if !defined(OS_ANDROID)
This change isn't obvious to me. Maybe "// Thumbnails are only used on the webui
NTP, which isn't used on Android." (assuming that's the reason)?

https://chromiumcodereview.appspot.com/256763004/diff/20001/chrome/browser/ui...
File chrome/browser/ui/webui/metrics_handler.cc (right):

https://chromiumcodereview.appspot.com/256763004/diff/20001/chrome/browser/ui...
chrome/browser/ui/webui/metrics_handler.cc:119: #if !defined(OS_ANDROID)
Do you need this? If this function isn't called, the linker will strip it. If it
is called, you probably want this code. (?)

[aurimas (slooooooooow), 2014-04-25 21:23:37]

https://chromiumcodereview.appspot.com/256763004/diff/20001/chrome/browser/se...
File chrome/browser/search/instant_service.cc (right):

https://chromiumcodereview.appspot.com/256763004/diff/20001/chrome/browser/se...
chrome/browser/search/instant_service.cc:112: #if !defined(OS_ANDROID)
On 2014/04/25 20:22:04, Nico wrote:
> This change isn't obvious to me. Maybe "// Thumbnails are only used on the
webui
> NTP, which isn't used on Android." (assuming that's the reason)?

We don't use instant_service.cc at on Android, but it is too hard to ifdef it
out. I will try to make a follow up CL trying to do that. For now, I'll add a
TODO(aurimas) to remove this ifdef.

https://chromiumcodereview.appspot.com/256763004/diff/20001/chrome/browser/ui...
File chrome/browser/ui/webui/metrics_handler.cc (right):

https://chromiumcodereview.appspot.com/256763004/diff/20001/chrome/browser/ui...
chrome/browser/ui/webui/metrics_handler.cc:119: #if !defined(OS_ANDROID)
On 2014/04/25 20:22:04, Nico wrote:
> Do you need this? If this function isn't called, the linker will strip it. If
it
> is called, you probably want this code. (?)

It actually fails to compile. This function get registered as a handler in
MetricsHandler::RegisterMessages.
 
Ideally both MetricsHandler::HandleLogEventTime and
MetricsHandler::HandleLogMouseover would move to a new class called
NewTabHanlder instead of living in this generic metrics_handler.cc.

[Nico, 2014-04-25 21:28:00]

(My expectation for "lgtm with questions why stuff happens" is that you add a
short explanation to these questions as comments in the code and then land. If
you've already added comments, please ignore this mail :-) )

[aurimas (slooooooooow), 2014-04-28 16:14:27]

isherman: PTAL

[Ilya Sherman, 2014-04-28 17:37:19]

histograms.xml lgtm

[aurimas (slooooooooow), 2014-04-28 17:38:07]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:39:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/256763004/60001

[commit-bot: I haz the power, 2014-04-28 18:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 18:14:25]

Try jobs failed on following builders:
  tryserver.chromium on android_clang_dbg

[aurimas (slooooooooow), 2014-04-28 23:32:29]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:33:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/256763004/80001

[commit-bot: I haz the power, 2014-04-29 05:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 05:26:44]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[aurimas (slooooooooow), 2014-04-29 17:25:28]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-04-29 17:26:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/256763004/100001

[aurimas (slooooooooow), 2014-04-29 17:52:23]

The CQ bit was unchecked by aurimas@chromium.org

[aurimas (slooooooooow), 2014-04-29 18:07:44]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-04-29 18:08:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/256763004/120001

[commit-bot: I haz the power, 2014-04-29 18:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 18:56:38]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium

[aurimas (slooooooooow), 2014-04-29 20:03:11]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-04-29 20:04:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/256763004/120001

[commit-bot: I haz the power, 2014-04-30 05:43:35]

Change committed as 267095

[falken, 2014-04-30 06:12:28]

On 2014/04/30 05:43:35, I haz the power (commit-bot) wrote:
> Change committed as 267095

chromium.webkit bot "Android Builder" has started failing and this change looks
suspicious. See:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds...