Issue 2645423002: Fix gtk theme regression introduced in 477aca494328f

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2645423002: Fix gtk theme regression introduced in 477aca494328f (Closed)

Created:
3 years, 11 months ago by Evan Stade

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Fix gtk theme regression introduced in 477aca494328f Turns out we do need to explicitly clear the border images. This bug is visible when you hover a toolbar button. BUG=682940 Review-Url: https://codereview.chromium.org/2639423005 Cr-Commit-Position: refs/heads/master@{#445130} (cherry picked from commit 7e2b5c14fa70447b692fab4f7a9660729cf55b38) Review-Url: https://codereview.chromium.org/2645423002 . Cr-Commit-Position: refs/branch-heads/2987@{#26} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/367cd558c1b77618d0d6a73298b5566fd7d3e988

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	chrome/browser/ui/libgtkui/gtk_ui.cc	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

Evan Stade

3 years, 11 months ago (2017-01-23 16:12:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
367cd558c1b77618d0d6a73298b5566fd7d3e988 (tree was closed).