Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2639423005: Fix gtk theme regression introduced in 477aca494328f (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gtk theme regression introduced in 477aca494328f Turns out we do need to explicitly clear the border images. This bug is visible when you hover a toolbar button. BUG=682940 Review-Url: https://codereview.chromium.org/2639423005 Cr-Commit-Position: refs/heads/master@{#445130} Committed: https://chromium.googlesource.com/chromium/src/+/7e2b5c14fa70447b692fab4f7a9660729cf55b38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Evan Stade
3 years, 11 months ago (2017-01-20 01:52:51 UTC) #2
Elliot Glaysher
lgtm
3 years, 11 months ago (2017-01-20 18:09:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639423005/1
3 years, 11 months ago (2017-01-20 19:28:03 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:34:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e2b5c14fa70447b692fab4f7a96...

Powered by Google App Engine
This is Rietveld 408576698