Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2645323003: Increase file length limit for w3c test importer (Closed)

Created:
3 years, 11 months ago by majidvp
Modified:
3 years, 11 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase file path length limit for w3c test importer Since the original limit was added the base path has been reduced by 15 chars.* Increasing the limit by this amount allows us to import more tests without breaking any existing windows bots. * from 'imported/web-platform-tests' to 'external/wpt' BUG=609871 Review-Url: https://codereview.chromium.org/2645323003 Cr-Commit-Position: refs/heads/master@{#445546} Committed: https://chromium.googlesource.com/chromium/src/+/706a4e2dceb1e19d8b74cff5a9cd8b04dc781b1d

Patch Set 1 #

Patch Set 2 : Increase file length limit for test importer #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 13 (8 generated)
majidvp
3 years, 11 months ago (2017-01-23 20:26:11 UTC) #2
majidvp
3 years, 11 months ago (2017-01-23 20:26:33 UTC) #4
qyearsley
lgtm https://codereview.chromium.org/2645323003/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right): https://codereview.chromium.org/2645323003/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py#newcode47 third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:47: MAX_PATH_LENGTH = 140 Let's see, if the path ...
3 years, 11 months ago (2017-01-23 21:04:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645323003/20001
3 years, 11 months ago (2017-01-23 21:17:25 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 23:45:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/706a4e2dceb1e19d8b74cff5a9cd...

Powered by Google App Engine
This is Rietveld 408576698