Increase file length limit for w3c test importer

third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

 # Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
 # are met:
 #
 # 1. Redistributions of source code must retain the above
 #    copyright notice, this list of conditions and the following
 #    disclaimer.
 # 2. Redistributions in binary form must reproduce the above
@@ skipping 26 matching lines @@
 import re
 
 from webkitpy.common.webkit_finder import WebKitFinder
 from webkitpy.layout_tests.models.test_expectations import TestExpectationParser
 from webkitpy.w3c.test_parser import TestParser
 from webkitpy.w3c.test_converter import convert_for_webkit
 
 # Maximum length of import path starting from top of source repository.
 # This limit is here because the Windows builders cannot create paths that are
 # longer than the Windows max path length (260). See http://crbug.com/609871.
-MAX_PATH_LENGTH = 125
+MAX_PATH_LENGTH = 140

[qyearsley, 2017/01/23 21:04:44]

Let's see, if the path to the Chromium repo were:

  "C:\b\build\slave\Win7_Release__NVIDIA_GeForce_730_\build\src" (60 characters)

then the path length we should allow would be around 260 - 60 = ~200

Of course, that's just assuming that base path; base path may be longer. So 140
sounds good to me :-)

 
 _log = logging.getLogger(__name__)
 
 
 class TestImporter(object):
 
     def __init__(self, host, source_repo_path, dest_dir_name='external'):
         """Initializes variables to prepare for copying and converting files.
 
         Args:
@@ skipping 289 matching lines @@
         """Checks whether a source path is too long to import.
 
         Args:
             Absolute path of file to be imported.
 
         Returns:
             True if the path is too long to import, False if it's OK.
         """
         path_from_repo_base = os.path.relpath(source_path, self.source_repo_path)
         return len(path_from_repo_base) > MAX_PATH_LENGTH