Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2645303002: Use a new Supplement constructor for supplements in core/ (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, kinuko+worker_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+prerender_chromium.org, tzik, iclelland+watch_chromuim.org, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, nhiroki, chasej+watch_chromium.org, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, shimazu+worker_chromium.org, horo+watch_chromium.org, blink-reviews, falken+watch_chromium.org, kinuko+watch, Nate Chapin, kinuko+fileapi, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a new Supplement constructor for supplements in core/ This is a step to deprecate the default Supplement constructor. BUG=610176 Review-Url: https://codereview.chromium.org/2645303002 Cr-Commit-Position: refs/heads/master@{#445363} Committed: https://chromium.googlesource.com/chromium/src/+/27e8f95e0a38ac53e85175b84a158da06da32eb0

Patch Set 1 #

Patch Set 2 : temp #

Total comments: 1

Patch Set 3 : temp #

Patch Set 4 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -56 lines) Patch
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParserTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PrerendererClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/PrerendererClient.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp View 7 chunks +16 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/InternalSettings.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/SharedWorkerPerformance.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/SharedWorkerPerformance.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/timing/WorkerGlobalScopePerformance.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/WorkerGlobalScopePerformance.cpp View 1 chunk +12 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/PrerendererClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PrerendererClientImpl.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-23 09:28:44 UTC) #2
sof
lgtm https://codereview.chromium.org/2645303002/diff/20001/third_party/WebKit/Source/core/fileapi/FileReader.cpp File third_party/WebKit/Source/core/fileapi/FileReader.cpp (right): https://codereview.chromium.org/2645303002/diff/20001/third_party/WebKit/Source/core/fileapi/FileReader.cpp#newcode129 third_party/WebKit/Source/core/fileapi/FileReader.cpp:129: ThrottlingController(ExecutionContext& context) nit: "explicit"
3 years, 11 months ago (2017-01-23 09:36:05 UTC) #3
haraken
> https://codereview.chromium.org/2645303002/diff/20001/third_party/WebKit/Source/core/fileapi/FileReader.cpp > File third_party/WebKit/Source/core/fileapi/FileReader.cpp (right): > > https://codereview.chromium.org/2645303002/diff/20001/third_party/WebKit/Source/core/fileapi/FileReader.cpp#newcode129 > third_party/WebKit/Source/core/fileapi/FileReader.cpp:129: > ThrottlingController(ExecutionContext& context) > ...
3 years, 11 months ago (2017-01-23 09:37:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645303002/40001
3 years, 11 months ago (2017-01-23 09:38:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/307777)
3 years, 11 months ago (2017-01-23 10:20:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645303002/60001
3 years, 11 months ago (2017-01-23 11:09:36 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 12:33:32 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/27e8f95e0a38ac53e85175b84a15...

Powered by Google App Engine
This is Rietveld 408576698