third_party/WebKit/Source/core/testing/InternalSettings.cpp - Issue 2645303002: Use a new Supplement constructor for supplements in core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/InternalSettings.cpp

Issue 2645303002: Use a new Supplement constructor for supplements in core/ (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/InternalSettings.cpp

diff --git a/third_party/WebKit/Source/core/testing/InternalSettings.cpp b/third_party/WebKit/Source/core/testing/InternalSettings.cpp

index 4e7ddbf4f474587f5cd24918e6467daff98cd6a8..6958a2743b8b6fd577876a51ed72ee3858400b77 100644

--- a/third_party/WebKit/Source/core/testing/InternalSettings.cpp

+++ b/third_party/WebKit/Source/core/testing/InternalSettings.cpp

@@ -131,7 +131,7 @@ InternalSettings::~InternalSettings() {}

InternalSettings::InternalSettings(Page& page)

: InternalSettingsGenerated(&page),

- m_page(&page),

+ Supplement<Page>(page),

m_backup(&page.settings()) {}

void InternalSettings::resetToConsistentState() {

@@ -371,7 +371,6 @@ void InternalSettings::setDefaultVideoPosterURL(

}

DEFINE_TRACE(InternalSettings) {

- visitor->trace(m_page);

InternalSettingsGenerated::trace(visitor);

Supplement<Page>::trace(visitor);

}