Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Issue 2645263003: Revert of Enable use-after-scope check in ASAN configs. (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
hans, achuithb, Nico, krasin1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable use-after-scope check in ASAN configs. (patchset #5 id:80001 of https://codereview.chromium.org/2451973004/ ) Reason for revert: This CL caused crashes in Linux ASAN. https://bugs.chromium.org/p/chromium/issues/detail?id=683459 Original issue's description: > Enable use-after-scope check in ASAN configs. > > At this point, everything but Mac has been fixed. On Mac, there's an outstanding issue, which will be fixed later. > > BUG=649897 > > Review-Url: https://codereview.chromium.org/2451973004 > Cr-Commit-Position: refs/heads/master@{#445114} > Committed: https://chromium.googlesource.com/chromium/src/+/866204443431a62c1b6e1404ed3c19c3f529ce45 TBR=thakis@chromium.org,hans@chromium.org,achuith@chromium.org,krasin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=649897 Review-Url: https://codereview.chromium.org/2645263003 Cr-Commit-Position: refs/heads/master@{#445331} Committed: https://chromium.googlesource.com/chromium/src/+/73ce07497d3279402d2f51a03e55be8c4612ff50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/config/sanitizers/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
haraken
Created Revert of Enable use-after-scope check in ASAN configs.
3 years, 11 months ago (2017-01-23 05:17:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645263003/1
3 years, 11 months ago (2017-01-23 05:17:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/73ce07497d3279402d2f51a03e55be8c4612ff50
3 years, 11 months ago (2017-01-23 07:42:08 UTC) #6
krasin1
3 years, 11 months ago (2017-01-23 18:44:54 UTC) #7
Message was sent while issue was closed.
On 2017/01/23 07:42:08, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/73ce07497d3279402d2f51a03e55...

LGTM

Hi Kentaro,

thank you for reverting the CL!

Powered by Google App Engine
This is Rietveld 408576698