Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2451973004:
Enable use-after-scope check in ASAN configs. (Closed)
DescriptionEnable use-after-scope check in ASAN configs.
At this point, everything but Mac has been fixed. On Mac, there's an outstanding issue, which will be fixed later.
BUG=649897
Review-Url: https://codereview.chromium.org/2451973004
Cr-Commit-Position: refs/heads/master@{#445114}
Committed: https://chromium.googlesource.com/chromium/src/+/866204443431a62c1b6e1404ed3c19c3f529ce45
Patch Set 1 #Patch Set 2 : Add a compile time flag too #Patch Set 3 : fix png_codec issue #Patch Set 4 : fmt #Patch Set 5 : exclude mac #
Total comments: 1
Messages
Total messages: 23 (17 generated)
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Description was changed from ========== Enable use-after-scope check in ASAN configs. BUG=649897 ========== to ========== Enable use-after-scope check in ASAN configs. At this point, everything but Mac has been fixed. On Mac, there's an outstanding issue, which will be fixed later. BUG=649897 ==========
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by krasin@chromium.org
krasin@chromium.org changed reviewers: + hans@chromium.org, thakis@chromium.org
lgtm
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484935386488070,
"parent_rev": "e11c34fb2c29ea47003a20391f0c7222b14b1e13", "commit_rev":
"866204443431a62c1b6e1404ed3c19c3f529ce45"}
Message was sent while issue was closed.
Description was changed from ========== Enable use-after-scope check in ASAN configs. At this point, everything but Mac has been fixed. On Mac, there's an outstanding issue, which will be fixed later. BUG=649897 ========== to ========== Enable use-after-scope check in ASAN configs. At this point, everything but Mac has been fixed. On Mac, there's an outstanding issue, which will be fixed later. BUG=649897 Review-Url: https://codereview.chromium.org/2451973004 Cr-Commit-Position: refs/heads/master@{#445114} Committed: https://chromium.googlesource.com/chromium/src/+/866204443431a62c1b6e1404ed3c... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/866204443431a62c1b6e1404ed3c...
Message was sent while issue was closed.
achuith@chromium.org changed reviewers: + achuith@chromium.org
Message was sent while issue was closed.
https://bugs.chromium.org/p/chromium/issues/detail?id=683445 https://codereview.chromium.org/2451973004/diff/80001/build/config/sanitizers... File build/config/sanitizers/BUILD.gn (right): https://codereview.chromium.org/2451973004/diff/80001/build/config/sanitizers... build/config/sanitizers/BUILD.gn:203: if (!is_mac) { Also not chromeos
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2645263003/ by haraken@chromium.org. The reason for reverting is: This CL caused crashes in Linux ASAN. https://bugs.chromium.org/p/chromium/issues/detail?id=683459 . |
