[WIP] ScreenManager: Add an external window mode

services/ui/display/screen_manager_ozone_unittests.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
@@ skipping 150 matching lines @@
 
     // Add NDD to ScreenManager so one isn't loaded from Ozone.
     screen_manager_->native_display_delegate_ = std::move(ndd);
 
     AddDisplay(FakeDisplaySnapshot::Builder()
                    .SetId(1)
                    .SetNativeMode(gfx::Size(1024, 768))
                    .SetType(DISPLAY_CONNECTION_TYPE_INTERNAL)
                    .Build());
 
-    screen_manager_->Init(&delegate_);
+    screen_manager_->Init(&delegate_, ScreenManager::WINDOW_MODE_INTERNAL);

[rjkroege, 2017/01/23 21:19:43]

This is not right in some fashion. One of the goals in this work is to use the
ozone wayland backend to support EXTERNAL window mode yes? So: the test should
be able to run with both INTERNAL and EXTERNAL? Right?

At a minimum: this needs a TODO() to say that the test should made to run with
external mode too?

[fwang, 2017/01/24 17:11:51]

I'll check that (BTW, note that this test is only executed on ChromeOS at the
moment and many other tests listed in this commit actually fails on non-ChromeOS
platforms).

     RunAllTasks();
 
     // Double check the expected display exists and clear counters.
     ASSERT_THAT(delegate()->added(), SizeIs(1));
     ASSERT_THAT(delegate_.added()[0], DisplayIdIs(1));
     ASSERT_THAT(delegate_.added()[0], DisplayBoundsIs("0,0 1024x768"));
     ASSERT_THAT(delegate_.added()[0], DisplayPixelSizeIs("1024x768"));
     ASSERT_EQ("Added(1);Primary(1)", delegate()->changes());
     delegate_.Reset();
   }
@@ skipping 94 matching lines @@
 
   // Swapping again should be similar and end up back with display 1 as primary.
   screen_manager()->SwapPrimaryDisplay();
   EXPECT_EQ("Modified(1);Modified(2);Primary(1)", delegate()->changes());
   EXPECT_THAT(delegate()->modified()[0], DisplayBoundsIs("0,0 1024x768"));
   EXPECT_THAT(delegate()->modified()[1], DisplayBoundsIs("1024,0 1024x768"));
   EXPECT_EQ(1, Screen::GetScreen()->GetPrimaryDisplay().id());
 }
 
 }  // namespace display