[WIP] ScreenManager: Add an external window mode

services/ui/display/screen_manager_ozone.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_UI_DISPLAY_SCREEN_MANAGER_OZONE_H_
 #define SERVICES_UI_DISPLAY_SCREEN_MANAGER_OZONE_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 30 matching lines @@
       public service_manager::InterfaceFactory<mojom::DisplayController>,
       public service_manager::InterfaceFactory<mojom::TestDisplayController> {
  public:
   ScreenManagerOzone();
   ~ScreenManagerOzone() override;
 
   void SetPrimaryDisplayId(int64_t display_id);
 
   // ScreenManager:
   void AddInterfaces(service_manager::InterfaceRegistry* registry) override;
-  void Init(ScreenManagerDelegate* delegate) override;
+  void Init(ScreenManagerDelegate* delegate, WindowMode window_mode) override;
   void RequestCloseDisplay(int64_t display_id) override;

[kylechar, 2017/01/25 13:04:48]

I don't think this is the right thing to do. ScreenManagerOzone is perhaps
poorly named and it should be ScreenManagerChromeOS or ScreenManagerInternal but
it's built for Chrome OS. It will only work for internal window mode and it
controls the size of root drawable surfaces. For external window mode
ScreenManager doesn't control the root drawable surfaces, so there isn't much /
any code overlap.

ScreenManagerOzone won't compile if target_os != "chromeos". I think you'll need
to write a different ScreenManager implementation for external window mode or
maybe you can use ScreenManagerStub for now. 

The bulk of the work to get external window mode working is the WS. Right now
each ws::Display corresponds to a root drawable surface. The ws::Display has a
ws::PlatformDisplay (which again isn't well named) which is basically what
allows you to draw to a surface, it owns the ui::PlatformWindow and
ws::FrameGenerator. The WS needs to be changed so that ws::Display doesn't own a
ws::PlatformDisplay. The top level Chrome ServerWindows need to own
ws::PlatformDisplay, which I guess means that a ServerWindow owns the
ws::PlatformDisplay in both external and internal window mode.

   int64_t GetPrimaryDisplayId() const override;
 
   // mojom::TestDisplayController:
   void ToggleAddRemoveDisplay() override;
   void ToggleDisplayResolution() override;
 
   // mojom::DisplayController:
   void IncreaseInternalDisplayZoom() override;
   void DecreaseInternalDisplayZoom() override;
   void ResetInternalDisplayZoom() override;
@@ skipping 49 matching lines @@
 
   mojo::BindingSet<mojom::DisplayController> controller_bindings_;
   mojo::BindingSet<mojom::TestDisplayController> test_bindings_;
 
   DISALLOW_COPY_AND_ASSIGN(ScreenManagerOzone);
 };
 
 }  // namespace display
 
 #endif  // SERVICES_UI_DISPLAY_SCREEN_MANAGER_OZONE_H_