Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2644933003: Revert of Move ImageLoader timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
Byoungkwon Ko
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ImageLoader timer to frame-specific TaskRunnerTimer. (patchset #2 id:20001 of https://codereview.chromium.org/2642103002/ ) Reason for revert: To the best of my knowledge, I guess this CL is going to be a culprit of the memory leak: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/1645 Let me revert this CL and see how it goes. I'll reland it if my guess is wrong. Original issue's description: > Move ImageLoader timer to frame-specific TaskRunnerTimer. > > Move ImageLoader timer m_derefElementTimer to frame-specific TaskRunnerTimer. > This associates it with the frame's Networking timer task queue. > > BUG=624694 > > Review-Url: https://codereview.chromium.org/2642103002 > Cr-Commit-Position: refs/heads/master@{#444927} > Committed: https://chromium.googlesource.com/chromium/src/+/ce1a9c0e454b08c96ca73788a1b4dccb405ce027 TBR=gogag2@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624694 Review-Url: https://codereview.chromium.org/2644933003 Cr-Commit-Position: refs/heads/master@{#445007} Committed: https://chromium.googlesource.com/chromium/src/+/c2e4a5276554d15581395ce6b5aec9023f0c6031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/core/loader/ImageLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
haraken
Created Revert of Move ImageLoader timer to frame-specific TaskRunnerTimer.
3 years, 11 months ago (2017-01-20 07:31:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644933003/1
3 years, 11 months ago (2017-01-20 07:31:23 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 07:33:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2e4a5276554d15581395ce6b5ae...

Powered by Google App Engine
This is Rietveld 408576698