Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2642103002:
Move ImageLoader timer to frame-specific TaskRunnerTimer. (Closed)
|
Created:
3 years, 11 months ago by Byoungkwon Ko Modified:
3 years, 11 months ago Reviewers:
haraken CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove ImageLoader timer to frame-specific TaskRunnerTimer.
Move ImageLoader timer m_derefElementTimer to frame-specific TaskRunnerTimer.
This associates it with the frame's Networking timer task queue.
BUG=624694
Review-Url: https://codereview.chromium.org/2642103002
Cr-Commit-Position: refs/heads/master@{#444927}
Committed: https://chromium.googlesource.com/chromium/src/+/ce1a9c0e454b08c96ca73788a1b4dccb405ce027
Patch Set 1 #Patch Set 2 : Move ImageLoader timer to frame-specific TaskRunnerTimer. #
Messages
Total messages: 20 (13 generated)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by gogag2@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gogag2@gmail.com changed reviewers: + haraken@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Move ImageLoader timer to frame-specific TaskRunnerTimer. Move ImageLoader timer m_derefElementTimer to frame-specific TaskRunnerTimer. This associates it with the frame's UserInteraction timer task queue. BUG=624694 ========== to ========== Move ImageLoader timer to frame-specific TaskRunnerTimer. Move ImageLoader timer m_derefElementTimer to frame-specific TaskRunnerTimer. This associates it with the frame's Networking timer task queue. BUG=624694 ==========
LGTM
The CQ bit was checked by gogag2@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484875050299280,
"parent_rev": "fc8514d40b8779930782ad4c80faca044958f0d9", "commit_rev":
"ce1a9c0e454b08c96ca73788a1b4dccb405ce027"}
Message was sent while issue was closed.
Description was changed from ========== Move ImageLoader timer to frame-specific TaskRunnerTimer. Move ImageLoader timer m_derefElementTimer to frame-specific TaskRunnerTimer. This associates it with the frame's Networking timer task queue. BUG=624694 ========== to ========== Move ImageLoader timer to frame-specific TaskRunnerTimer. Move ImageLoader timer m_derefElementTimer to frame-specific TaskRunnerTimer. This associates it with the frame's Networking timer task queue. BUG=624694 Review-Url: https://codereview.chromium.org/2642103002 Cr-Commit-Position: refs/heads/master@{#444927} Committed: https://chromium.googlesource.com/chromium/src/+/ce1a9c0e454b08c96ca73788a1b4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ce1a9c0e454b08c96ca73788a1b4...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2644933003/ by haraken@chromium.org. The reason for reverting is: To the best of my knowledge, I guess this CL is going to be a culprit of the memory leak: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty... Let me revert this CL and see how it goes. I'll reland it if my guess is wrong. .
Message was sent while issue was closed.
On 2017/01/20 07:31:07, haraken wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2644933003/ by mailto:haraken@chromium.org. > > The reason for reverting is: To the best of my knowledge, I guess this CL is > going to be a culprit of the memory leak: > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty... > > Let me revert this CL and see how it goes. I'll reland it if my guess is wrong. > . I think the memory leak is related to https://codereview.chromium.org/2642863002/
Message was sent while issue was closed.
On 2017/01/20 07:33:18, haraken wrote: > On 2017/01/20 07:31:07, haraken wrote: > > A revert of this CL (patchset #2 id:20001) has been created in > > https://codereview.chromium.org/2644933003/ by mailto:haraken@chromium.org. > > > > The reason for reverting is: To the best of my knowledge, I guess this CL is > > going to be a culprit of the memory leak: > > > > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty... > > > > Let me revert this CL and see how it goes. I'll reland it if my guess is > wrong. > > . > > I think the memory leak is related to > https://codereview.chromium.org/2642863002/ This is hitting the same problem as https://codereview.chromium.org/2642863002/. Given that timerFired() may not be called, we need to call m_keepAlive.clear() when the frame gets detached. You can do that by inheriting from ContextLifecycleObserver and call m_keepAlive.clear() in ContextLifecycleObserver::contextDestroyed(). However, it's error-prone that developers have to assume that timers may not run. I'm discussing how to deal with this issue in https://codereview.chromium.org/2642863002/. (BTW, I noticed that this task should use UnspecedTimer, not Networking. m_keepAlive.clear() is definitely an internal task.) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
