Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2644833002: Worker: Consolidate postTask implementation (Closed)

Created:
3 years, 11 months ago by nhiroki
Modified:
3 years, 11 months ago
Reviewers:
tzik
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Consolidate postTask implementation WorkerGlobalScope and ThreadedWorkletGlobalScope have the same implementation of postTask(). These should be consolidated into WorkerOrWorkletGlobalScope::postTask(). BUG=625927 Review-Url: https://codereview.chromium.org/2644833002 Cr-Commit-Position: refs/heads/master@{#444673} Committed: https://chromium.googlesource.com/chromium/src/+/04ff6239687ee823e9aa66254e4d506958366c7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -33 lines) Patch
M third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkletGlobalScope.h View 1 chunk +0 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
nhiroki
ptal, thanks!
3 years, 11 months ago (2017-01-19 06:00:59 UTC) #4
tzik
lgtm
3 years, 11 months ago (2017-01-19 06:36:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644833002/1
3 years, 11 months ago (2017-01-19 06:43:07 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 07:27:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04ff6239687ee823e9aa66254e4d...

Powered by Google App Engine
This is Rietveld 408576698