Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2640813006: Worker: Move instrumentation flag check from WorkerThread to WorkerOrWorkletGlobalScope (Closed)

Created:
3 years, 11 months ago by nhiroki
Modified:
3 years, 11 months ago
Reviewers:
tzik
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Move instrumentation flag check from WorkerThread to WorkerOrWorkletGlobalScope WorkerThread::postTask checks a flag of DevTools instrumentation, but this flag is set here only when it's called from WorkerOrWorkletGlobalScope::postTask. For cleanup, this CL moves the check from WorkerThread to WorkerOrWorkletGlobalScope. BUG=625927 Review-Url: https://codereview.chromium.org/2640813006 Cr-Commit-Position: refs/heads/master@{#444688} Committed: https://chromium.googlesource.com/chromium/src/+/e8a03e2020bf9aad333ae60eb57541e7eafb4f24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp View 2 chunks +22 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 2 chunks +3 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
nhiroki
PTAL, thanks!
3 years, 11 months ago (2017-01-19 07:12:54 UTC) #4
tzik
lgtm
3 years, 11 months ago (2017-01-19 07:45:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640813006/1
3 years, 11 months ago (2017-01-19 07:49:58 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 09:22:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8a03e2020bf9aad333ae60eb575...

Powered by Google App Engine
This is Rietveld 408576698