Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2644803002: Convert timer for InspectorOverlay (Closed)

Created:
3 years, 11 months ago by slangley
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert timer for InspectorOverlay to TaskRunnerTimer. This is part of a larger effort to convert usages of global Timers to frame-specific timers. As ExternalPopupMenu is not spec'd I have used UnspecifiedTimer as the type. BUG=624694 Review-Url: https://codereview.chromium.org/2644803002 Cr-Commit-Position: refs/heads/master@{#453908} Committed: https://chromium.googlesource.com/chromium/src/+/b1493a9acfbd71a7ced698bc0b989f57a7082c7d

Patch Set 1 #

Patch Set 2 : Used UnspecedTimer for the task type. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
slangley
3 years, 11 months ago (2017-01-19 04:17:13 UTC) #3
joelhockey
lgtm
3 years, 11 months ago (2017-01-19 04:46:23 UTC) #4
slangley
haraken@ - ptal
3 years, 9 months ago (2017-03-01 00:48:04 UTC) #6
haraken
Inspector is not a speced concept. So we should use UnspecedTimer.
3 years, 9 months ago (2017-03-01 01:12:38 UTC) #7
slangley
haraken@ - ptal
3 years, 9 months ago (2017-03-01 06:23:09 UTC) #9
haraken
LGTM
3 years, 9 months ago (2017-03-01 06:34:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644803002/20001
3 years, 9 months ago (2017-03-01 10:11:38 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 11:44:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b1493a9acfbd71a7ced698bc0b98...

Powered by Google App Engine
This is Rietveld 408576698