Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2644803002: Convert timer for InspectorOverlay (Closed)
Patch Set: Used UnspecedTimer for the task type. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 17 matching lines...) Expand all
28 28
29 #include "web/InspectorOverlay.h" 29 #include "web/InspectorOverlay.h"
30 30
31 #include <memory> 31 #include <memory>
32 32
33 #include "bindings/core/v8/ScriptController.h" 33 #include "bindings/core/v8/ScriptController.h"
34 #include "bindings/core/v8/ScriptSourceCode.h" 34 #include "bindings/core/v8/ScriptSourceCode.h"
35 #include "bindings/core/v8/V8InspectorOverlayHost.h" 35 #include "bindings/core/v8/V8InspectorOverlayHost.h"
36 #include "core/dom/Node.h" 36 #include "core/dom/Node.h"
37 #include "core/dom/StaticNodeList.h" 37 #include "core/dom/StaticNodeList.h"
38 #include "core/dom/TaskRunnerHelper.h"
38 #include "core/frame/FrameHost.h" 39 #include "core/frame/FrameHost.h"
39 #include "core/frame/FrameView.h" 40 #include "core/frame/FrameView.h"
40 #include "core/frame/LocalFrame.h" 41 #include "core/frame/LocalFrame.h"
41 #include "core/frame/LocalFrameClient.h" 42 #include "core/frame/LocalFrameClient.h"
42 #include "core/frame/Settings.h" 43 #include "core/frame/Settings.h"
43 #include "core/frame/VisualViewport.h" 44 #include "core/frame/VisualViewport.h"
44 #include "core/input/EventHandler.h" 45 #include "core/input/EventHandler.h"
45 #include "core/inspector/InspectorOverlayHost.h" 46 #include "core/inspector/InspectorOverlayHost.h"
46 #include "core/layout/api/LayoutViewItem.h" 47 #include "core/layout/api/LayoutViewItem.h"
47 #include "core/loader/EmptyClients.h" 48 #include "core/loader/EmptyClients.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 Member<ChromeClient> m_client; 176 Member<ChromeClient> m_client;
176 Member<InspectorOverlay> m_overlay; 177 Member<InspectorOverlay> m_overlay;
177 }; 178 };
178 179
179 InspectorOverlay::InspectorOverlay(WebLocalFrameImpl* frameImpl) 180 InspectorOverlay::InspectorOverlay(WebLocalFrameImpl* frameImpl)
180 : m_frameImpl(frameImpl), 181 : m_frameImpl(frameImpl),
181 m_overlayHost(InspectorOverlayHost::create()), 182 m_overlayHost(InspectorOverlayHost::create()),
182 m_drawViewSize(false), 183 m_drawViewSize(false),
183 m_resizeTimerActive(false), 184 m_resizeTimerActive(false),
184 m_omitTooltip(false), 185 m_omitTooltip(false),
185 m_timer(this, &InspectorOverlay::onTimer), 186 m_timer(
187 TaskRunnerHelper::get(TaskType::UnspecedTimer, frameImpl->frame()),
188 this,
189 &InspectorOverlay::onTimer),
186 m_suspended(false), 190 m_suspended(false),
187 m_showReloadingBlanket(false), 191 m_showReloadingBlanket(false),
188 m_inLayout(false), 192 m_inLayout(false),
189 m_needsUpdate(false), 193 m_needsUpdate(false),
190 m_inspectMode(InspectorDOMAgent::NotSearching) {} 194 m_inspectMode(InspectorDOMAgent::NotSearching) {}
191 195
192 InspectorOverlay::~InspectorOverlay() { 196 InspectorOverlay::~InspectorOverlay() {
193 DCHECK(!m_overlayPage); 197 DCHECK(!m_overlayPage);
194 } 198 }
195 199
(...skipping 591 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 bool InspectorOverlay::shouldSearchForNode() { 791 bool InspectorOverlay::shouldSearchForNode() {
788 return m_inspectMode != InspectorDOMAgent::NotSearching; 792 return m_inspectMode != InspectorDOMAgent::NotSearching;
789 } 793 }
790 794
791 void InspectorOverlay::inspect(Node* node) { 795 void InspectorOverlay::inspect(Node* node) {
792 if (m_domAgent) 796 if (m_domAgent)
793 m_domAgent->inspect(node); 797 m_domAgent->inspect(node);
794 } 798 }
795 799
796 } // namespace blink 800 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698