Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2644793006: Add picker view for Web Share Target. (Closed)

Created:
3 years, 11 months ago by Matt Giuca
Modified:
3 years, 10 months ago
Reviewers:
constantina, sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add picker view for Web Share Target. This is temporary UI which has not been approved by UX and will only be used for an experimental feature behind a flag. Hooked up to the share service for navigator.share on Desktop. Currently does not show any real apps (just the dummy app which is currently hard-coded in the share service). BUG=668389 Review-Url: https://codereview.chromium.org/2644793006 Cr-Commit-Position: refs/heads/master@{#447187} Committed: https://chromium.googlesource.com/chromium/src/+/39e40676d8769fade0dca9fc864eb5e2ef80ee58

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Total comments: 16

Patch Set 3 : Rename target_picker_view.h to webshare_target_picker_view.h. #

Patch Set 4 : Other fixes suggested by sky@. #

Patch Set 5 : Fix unit tests and add cancellation test (adds virtual method to Impl class). #

Total comments: 2

Patch Set 6 : Remove 'explicit'. #

Patch Set 7 : Fix compile error on Mac/Android. Had to move enum around. #

Patch Set 8 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 7 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 2 3 4 5 6 7 2 chunks +10 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/webshare/webshare_target_picker_view.h View 1 2 3 4 5 6 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/webshare/webshare_target_picker_view.cc View 1 2 3 4 5 6 1 chunk +108 lines, -0 lines 0 comments Download
M chrome/browser/webshare/share_service_impl.h View 1 2 3 4 5 6 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/webshare/share_service_impl.cc View 1 2 3 4 5 6 3 chunks +33 lines, -0 lines 0 comments Download
M chrome/browser/webshare/share_service_impl_unittest.cc View 1 2 3 4 5 6 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (21 generated)
Matt Giuca
3 years, 11 months ago (2017-01-20 04:31:05 UTC) #2
constantina
LGTM https://codereview.chromium.org/2644793006/diff/1/chrome/browser/webshare/share_service_impl.cc File chrome/browser/webshare/share_service_impl.cc (right): https://codereview.chromium.org/2644793006/diff/1/chrome/browser/webshare/share_service_impl.cc#newcode129 chrome/browser/webshare/share_service_impl.cc:129: // TODO(constantina): Replace hard-coded name with the registered ...
3 years, 11 months ago (2017-01-20 05:23:44 UTC) #3
Matt Giuca
sky@chromium.org: Please review changes in chrome/browser (browser_dialogs.h and views code). Please note that this hasn't ...
3 years, 11 months ago (2017-01-23 04:05:27 UTC) #5
sky
Matt, Could you clarify why you need "temporary UX for experimentation behind a flag"? We ...
3 years, 11 months ago (2017-01-23 16:28:23 UTC) #10
sky
https://codereview.chromium.org/2644793006/diff/20001/chrome/browser/ui/views/webshare/target_picker_view.cc File chrome/browser/ui/views/webshare/target_picker_view.cc (right): https://codereview.chromium.org/2644793006/diff/20001/chrome/browser/ui/views/webshare/target_picker_view.cc#newcode59 chrome/browser/ui/views/webshare/target_picker_view.cc:59: if (RowCount() > 0) I would think this would ...
3 years, 11 months ago (2017-01-23 16:38:56 UTC) #11
Matt Giuca
On 2017/01/23 16:28:23, sky wrote: > Matt, > > Could you clarify why you need ...
3 years, 11 months ago (2017-01-24 06:49:37 UTC) #12
Matt Giuca
PTAL. https://codereview.chromium.org/2644793006/diff/20001/chrome/browser/ui/views/webshare/target_picker_view.cc File chrome/browser/ui/views/webshare/target_picker_view.cc (right): https://codereview.chromium.org/2644793006/diff/20001/chrome/browser/ui/views/webshare/target_picker_view.cc#newcode59 chrome/browser/ui/views/webshare/target_picker_view.cc:59: if (RowCount() > 0) On 2017/01/23 16:38:55, sky ...
3 years, 10 months ago (2017-01-30 04:07:13 UTC) #13
sky
LGTM https://codereview.chromium.org/2644793006/diff/80001/chrome/browser/ui/views/webshare/webshare_target_picker_view.h File chrome/browser/ui/views/webshare/webshare_target_picker_view.h (right): https://codereview.chromium.org/2644793006/diff/80001/chrome/browser/ui/views/webshare/webshare_target_picker_view.h#newcode30 chrome/browser/ui/views/webshare/webshare_target_picker_view.h:30: explicit WebShareTargetPickerView( remove explicit
3 years, 10 months ago (2017-01-30 17:09:37 UTC) #18
Matt Giuca
I had to move the enum into share_service_impl.h and #include that from browser_dialogs to get ...
3 years, 10 months ago (2017-01-30 23:34:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644793006/120001
3 years, 10 months ago (2017-01-31 02:19:19 UTC) #26
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-01-31 02:25:45 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644793006/140001
3 years, 10 months ago (2017-01-31 03:02:57 UTC) #31
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 04:18:07 UTC) #34
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/39e40676d8769fade0dca9fc864e...

Powered by Google App Engine
This is Rietveld 408576698