Add picker view for Web Share Target.

chrome/browser/ui/views/webshare/target_picker_view.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_WEBSHARE_TARGET_PICKER_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_WEBSHARE_TARGET_PICKER_VIEW_H_
+
+#include <vector>
+
+#include "base/callback.h"
+#include "base/macros.h"
+#include "base/strings/string16.h"
+#include "ui/base/models/table_model.h"
+#include "ui/base/ui_base_types.h"
+#include "ui/views/window/dialog_delegate.h"
+
+// Dialog that presents the user with a list of share target apps. Allows the
+// user to pick one target to be opened and have data passed to it.

[sky, 2017/01/23 16:38:56]

I don't see the selection in the table used in anyway. Am I missing something?

[Matt Giuca, 2017/01/30 04:07:13]

We don't yet have the real data about what apps to show here (I'm just setting
up the framework). constantina@ will implement this in a follow-up CL.

+//
+// NOTE: This dialog has *not* been UI-reviewed, and is being used by an
+// in-development feature (Web Share) behind a runtime flag. It should not be
+// used by any released code until going through UI review.
+class WebShareTargetPickerView : public views::DialogDelegateView,

[sky, 2017/01/23 16:38:55]

File name should match class name.

[Matt Giuca, 2017/01/30 04:07:13]

OK, renamed file to webshare_target_picker_view.

+                                 public ui::TableModel {
+ public:
+  explicit WebShareTargetPickerView(
+      const std::vector<base::string16>& targets,
+      const base::Callback<void(bool)>& close_callback);

[sky, 2017/01/23 16:38:55]

Document what 'close_callback' is and when called. Also, a boolean parameter is
not at all obvious. An enum would be much clearer.

[Matt Giuca, 2017/01/30 04:07:12]

Done. (Note: It had to be added to browser_dialogs.h since that's the public
interface to this dialog.)

+  ~WebShareTargetPickerView() override;
+
+  // Initializes the controls in the dialog.
+  void InitControls();

[sky, 2017/01/23 16:38:55]

Make private (or just move into constructor).

[Matt Giuca, 2017/01/30 04:07:12]

Done.

+
+  // views::View overrides:
+  gfx::Size GetPreferredSize() const override;
+
+  // views::WidgetDelegate overrides:
+  ui::ModalType GetModalType() const override;
+  base::string16 GetWindowTitle() const override;
+
+  // views::DialogDelegate overrides:
+  bool Cancel() override;
+  bool Accept() override;
+  base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
+
+  // ui::TableModel overrides:
+  int RowCount() override;
+  base::string16 GetText(int row, int column_id) override;
+  void SetObserver(ui::TableModelObserver* observer) override;
+
+ protected:

[sky, 2017/01/23 16:38:55]

private (see style guide).

[Matt Giuca, 2017/01/30 04:07:12]

Lol whoops, I copypastad this from another file :) (wouldn't write this).

+  std::vector<base::string16> targets_;

[sky, 2017/01/23 16:38:55]

const

[Matt Giuca, 2017/01/30 04:07:12]

Done.

+
+  base::Callback<void(bool)> close_callback_;
+
+  DISALLOW_COPY_AND_ASSIGN(WebShareTargetPickerView);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_WEBSHARE_TARGET_PICKER_VIEW_H_