Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 2644683002: Add HpackDecoder3, an adapter using HpackDecoder (in net/http2/hpack/decoder). (Closed)

Created:
3 years, 11 months ago by Bence
Modified:
3 years, 11 months ago
Reviewers:
dahollings
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HpackDecoder3, an adapter using HpackDecoder (in net/http2/hpack/decoder). Add FLAGS_chromium_http2_flag_spdy_use_hpack_decoder3. Modify SpdyFramer::GetHpackDecoder to create an HpackDecoder3 if this new flag is set. Extend the parameterized tests in quic_headers_stream_test.cc and spdy_framer_test.cc to include testing of HpackDecoder3. This CL lands server change 131193186 by jamessynge and 132112978 by rch. BUG=488484 Review-Url: https://codereview.chromium.org/2644683002 Cr-Commit-Position: refs/heads/master@{#444820} Committed: https://chromium.googlesource.com/chromium/src/+/c672030ee55a11d14f60214fce808d41761c383f

Patch Set 1 #

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -107 lines) Patch
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 5 chunks +19 lines, -10 lines 0 comments Download
M net/spdy/hpack/hpack_decoder2_test.cc View 3 chunks +9 lines, -4 lines 0 comments Download
A net/spdy/hpack/hpack_decoder3.h View 1 1 chunk +112 lines, -0 lines 0 comments Download
A net/spdy/hpack/hpack_decoder3.cc View 1 chunk +151 lines, -0 lines 0 comments Download
A + net/spdy/hpack/hpack_decoder3_test.cc View 1 33 chunks +136 lines, -78 lines 0 comments Download
M net/spdy/hpack/hpack_decoder_interface.h View 2 chunks +8 lines, -1 line 0 comments Download
M net/spdy/hpack/hpack_decoder_test.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M net/spdy/spdy_flags.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_flags.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/spdy/spdy_framer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/spdy/spdy_framer_test.cc View 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Bence
dahollings: PTAL. Thanks.
3 years, 11 months ago (2017-01-19 13:02:18 UTC) #10
dahollings
lgtm
3 years, 11 months ago (2017-01-19 19:44:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644683002/20001
3 years, 11 months ago (2017-01-19 19:44:41 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 19:53:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c672030ee55a11d14f60214fce80...

Powered by Google App Engine
This is Rietveld 408576698