Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: net/spdy/hpack/hpack_decoder2_test.cc

Issue 2644683002: Add HpackDecoder3, an adapter using HpackDecoder (in net/http2/hpack/decoder). (Closed)
Patch Set: Nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_headers_stream_test.cc ('k') | net/spdy/hpack/hpack_decoder3.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack/hpack_decoder2_test.cc
diff --git a/net/spdy/hpack/hpack_decoder2_test.cc b/net/spdy/hpack/hpack_decoder2_test.cc
index efea044d19556dcdc6e047f88d7a163f29409a98..8c70051e2c13447766978cc60284a13da6d45c58 100644
--- a/net/spdy/hpack/hpack_decoder2_test.cc
+++ b/net/spdy/hpack/hpack_decoder2_test.cc
@@ -565,8 +565,9 @@ TEST_P(HpackDecoder2Test, HuffmanEOSError) {
EXPECT_FALSE(DecodeHeaderBlock(first));
}
-// Round-tripping the header set from E.2.1 should work.
-TEST_P(HpackDecoder2Test, BasicE21) {
+// Round-tripping the header set from RFC 7541 C.3.1 should work.
+// http://httpwg.org/specs/rfc7541.html#rfc.section.C.3.1
+TEST_P(HpackDecoder2Test, BasicC31) {
HpackEncoder encoder(ObtainHpackHuffmanTable());
SpdyHeaderBlock expected_header_set;
@@ -583,7 +584,9 @@ TEST_P(HpackDecoder2Test, BasicE21) {
EXPECT_EQ(expected_header_set, decoded_block());
}
-TEST_P(HpackDecoder2Test, SectionD4RequestHuffmanExamples) {
+// RFC 7541, Section C.4: Request Examples with Huffman Coding
+// http://httpwg.org/specs/rfc7541.html#rfc.section.C.4
+TEST_P(HpackDecoder2Test, SectionC4RequestHuffmanExamples) {
// TODO(jamessynge): Use net/http2/hpack/tools/hpack_example.h to parse the
// example directly, instead of having it as a comment.
// 82 | == Indexed - Add ==
@@ -703,7 +706,9 @@ TEST_P(HpackDecoder2Test, SectionD4RequestHuffmanExamples) {
EXPECT_EQ(164u, decoder_peer_.header_table()->size());
}
-TEST_P(HpackDecoder2Test, SectionD6ResponseHuffmanExamples) {
+// RFC 7541, Section C.6: Response Examples with Huffman Coding
+// http://httpwg.org/specs/rfc7541.html#rfc.section.C.6
+TEST_P(HpackDecoder2Test, SectionC6ResponseHuffmanExamples) {
decoder_.ApplyHeaderTableSizeSetting(256);
// 48 | == Literal indexed ==
« no previous file with comments | « net/quic/core/quic_headers_stream_test.cc ('k') | net/spdy/hpack/hpack_decoder3.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698