Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2644643003: Send CrashReporting notification from didCommitNavigationWithDetails:. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send CrashReporting notification from didCommitNavigationWithDetails:. This notification was previously sent from deprecated webDidStartLoadingURL:shouldUpdateHistory: method, which should be removed. After this CL notification is now sent before |countMainFrameLoad| and |addCurrentEntryToHistoryDB| calls, which should not cause any issues as calls order should not matter. BUG=674991 Review-Url: https://codereview.chromium.org/2644643003 Cr-Commit-Position: refs/heads/master@{#444749} Committed: https://chromium.googlesource.com/chromium/src/+/0804ab91e011cdf3c20f0ca837222d8f3414a72a

Patch Set 1 #

Patch Set 2 : Fixed compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 4 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-19 01:20:29 UTC) #10
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-19 09:54:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644643003/20001
3 years, 11 months ago (2017-01-19 16:02:21 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 16:08:00 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0804ab91e011cdf3c20f0ca83722...

Powered by Google App Engine
This is Rietveld 408576698