Send CrashReporting notification from didCommitNavigationWithDetails:.

ios/chrome/browser/tabs/tab.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/tabs/tab.h"
 
 #import <CoreLocation/CoreLocation.h>
 #import <UIKit/UIKit.h>
 
 #include <utility>
@@ skipping 1750 matching lines @@
 }
 
 - (void)webState:(web::WebState*)webState
     didCommitNavigationWithDetails:(const web::LoadCommittedDetails&)details {
   DCHECK([self navigationManager]);
   // |webWillAddPendingURL:transition:| is not called for native page loads.
   // TODO(crbug.com/381201): Move this call there once that bug is fixed so that
   // |disableFullScreen| is called only from one place.
   [fullScreenController_ disableFullScreen];
   [findInPageController_ disableFindInPageWithCompletionHandler:nil];
-  [autoReloadBridge_ loadStartedForURL:webState->GetLastCommittedURL()];
+  GURL lastCommittedURL = webState->GetLastCommittedURL();
+  [autoReloadBridge_ loadStartedForURL:lastCommittedURL];
 
   if (isUserNavigationEvent_) {
     [[NSNotificationCenter defaultCenter]
         postNotificationName:kTabModelUserNavigatedNotification
                       object:self];
   }
   if (parentTabModel_) {
     [[NSNotificationCenter defaultCenter]
         postNotificationName:kTabModelTabWillStartLoadingNotification
                       object:parentTabModel_
                     userInfo:@{kTabModelTabKey : self}];
   }
   favicon::FaviconDriver* faviconDriver =
       favicon::WebFaviconDriver::FromWebState(webState);
   if (faviconDriver) {
-    faviconDriver->FetchFavicon(webState->GetLastCommittedURL());
+    faviconDriver->FetchFavicon(lastCommittedURL);
   }
   [parentTabModel_ notifyTabChanged:self];
   if (parentTabModel_) {
     [[NSNotificationCenter defaultCenter]
         postNotificationName:kTabModelTabDidStartLoadingNotification
                       object:parentTabModel_
                     userInfo:@{kTabModelTabKey : self}];
   }
   [parentTabModel_ navigationCommittedInTab:self];
+
+  // Sending a notification about the url change for crash reporting.
+  // TODO(crbug.com/661675): Consider using the navigation entry committed
+  // notification now that it's in the right place.
+  NSString* URLSpec = base::SysUTF8ToNSString(lastCommittedURL.spec());
+  if (URLSpec.length) {
+    [[NSNotificationCenter defaultCenter]
+        postNotificationName:kTabUrlStartedLoadingNotificationForCrashReporting
+                      object:self
+                    userInfo:@{kTabUrlKey : URLSpec}];
+  }
 }
 
 // Called when the page URL has changed.
 - (void)webDidStartLoadingURL:(const GURL&)currentUrl
           shouldUpdateHistory:(BOOL)updateHistory {
   if (updateHistory) {
     [self addCurrentEntryToHistoryDB];
     [self countMainFrameLoad];
   }
-
-  // Sending a notification about the url change for crash reporting.
-  // TODO(crbug.com/661675): Consider using the navigation entry committed
-  // notification now that it's in the right place.
-  NSString* urlString = base::SysUTF8ToNSString(currentUrl.spec());
-  if ([urlString length]) {
-    [[NSNotificationCenter defaultCenter]
-        postNotificationName:kTabUrlStartedLoadingNotificationForCrashReporting
-                      object:self
-                    userInfo:[NSDictionary dictionaryWithObject:urlString
-                                                         forKey:kTabUrlKey]];
-  }
 }
 
 - (void)webState:(web::WebState*)webState
     didLoadPageWithSuccess:(BOOL)loadSuccess {
   DCHECK(self.webController.loadPhase == web::PAGE_LOADED);
 
   // Cancel prerendering if response is "application/octet-stream". It can be a
   // video file which should not be played from preload tab (crbug.com/436813).
   if (isPrerenderTab_ &&
       self.webState->GetContentsMimeType() == "application/octet-stream") {
@@ skipping 521 matching lines @@
 
 - (TabModel*)parentTabModel {
   return parentTabModel_;
 }
 
 - (FormInputAccessoryViewController*)inputAccessoryViewController {
   return inputAccessoryViewController_.get();
 }
 
 @end