Add KURL::protocolIsJavascript member function

Add KURL::protocolIsJavascript member function

Javascript URLs have weird rules in Blink. Even if the URL is invalid, many
systems would like to know if the URL has a javascript protocol. Using
KURL::protocol does not work, because for invalid URLs it results in the empty
string.

Previously, systems used blink::protocolIsJavascript, which calls into 
url::FindAndCompareScheme. However, a StringView approach with the
already-canonicalized URL is good enough and more efficient, as it doesn't
scan for whitespace and can quickly fail with a length mismatch.

Also, callers were passing Strings around instead of KURLs, so this tightens 
the KURL interface.

BUG=348655
Review-Url: https://codereview.chromium.org/2644633006
Cr-Commit-Position: refs/heads/master@{#445481}
Committed: https://chromium.googlesource.com/chromium/src/+/43d920ee6dea456674a0baa54506ec4da3cc6a85

[Charlie Harrison, 2017-01-20 05:35:04]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 05:35:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 08:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 08:49:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Harrison, 2017-01-20 13:40:39]

Description was changed from

==========
Clean up protocolIsJavascript

BUG=
==========

to

==========
Add KURL::protocolIsJavascript member function

Javascript URLs have weird rules in Blink. Even if the URL is invalid, many
systems would like to know if the URL has a javascript protocol. Using
KURL::protocol does not work, because for invalid URLs it results in the empty
string.

Previously, systems used blink::protocolIsJavascript, which calls into 
url::FindAndCompareScheme. However, a StringView approach with the
already-canonicalized URL is good enough and more efficient, as it doesn't
scan for whitespace and can quickly fail with a length mismatch.

Also, callers were passing Strings around instead of KURLs, so this tightens 
the KURL interface.

BUG=TODO
==========

[Charlie Harrison, 2017-01-20 13:50:08]

csharrison@chromium.org changed reviewers:
+ mkwst@chromium.org

[Charlie Harrison, 2017-01-20 13:50:08]

mkwst: Would you take a look here?

[Mike West, 2017-01-23 06:42:23]

On 2017/01/20 at 13:50:08, csharrison wrote:
> mkwst: Would you take a look here?

LGTM. Seems like a saner way of doing this, thanks!

[Charlie Harrison, 2017-01-23 18:52:15]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2017-01-23 18:52:36]

Description was changed from

==========
Add KURL::protocolIsJavascript member function

Javascript URLs have weird rules in Blink. Even if the URL is invalid, many
systems would like to know if the URL has a javascript protocol. Using
KURL::protocol does not work, because for invalid URLs it results in the empty
string.

Previously, systems used blink::protocolIsJavascript, which calls into 
url::FindAndCompareScheme. However, a StringView approach with the
already-canonicalized URL is good enough and more efficient, as it doesn't
scan for whitespace and can quickly fail with a length mismatch.

Also, callers were passing Strings around instead of KURLs, so this tightens 
the KURL interface.

BUG=TODO
==========

to

==========
Add KURL::protocolIsJavascript member function

Javascript URLs have weird rules in Blink. Even if the URL is invalid, many
systems would like to know if the URL has a javascript protocol. Using
KURL::protocol does not work, because for invalid URLs it results in the empty
string.

Previously, systems used blink::protocolIsJavascript, which calls into 
url::FindAndCompareScheme. However, a StringView approach with the
already-canonicalized URL is good enough and more efficient, as it doesn't
scan for whitespace and can quickly fail with a length mismatch.

Also, callers were passing Strings around instead of KURLs, so this tightens 
the KURL interface.

BUG=348655
==========

[commit-bot: I haz the power, 2017-01-23 18:52:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 20:59:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485197535226760, "parent_rev":
"8071d70e62d7c427491aa5e268b5f09dc887cca9", "commit_rev":
"43d920ee6dea456674a0baa54506ec4da3cc6a85"}

[commit-bot: I haz the power, 2017-01-23 20:59:58]

Description was changed from

==========
Add KURL::protocolIsJavascript member function

Javascript URLs have weird rules in Blink. Even if the URL is invalid, many
systems would like to know if the URL has a javascript protocol. Using
KURL::protocol does not work, because for invalid URLs it results in the empty
string.

Previously, systems used blink::protocolIsJavascript, which calls into 
url::FindAndCompareScheme. However, a StringView approach with the
already-canonicalized URL is good enough and more efficient, as it doesn't
scan for whitespace and can quickly fail with a length mismatch.

Also, callers were passing Strings around instead of KURLs, so this tightens 
the KURL interface.

BUG=348655
==========

to

==========
Add KURL::protocolIsJavascript member function

Javascript URLs have weird rules in Blink. Even if the URL is invalid, many
systems would like to know if the URL has a javascript protocol. Using
KURL::protocol does not work, because for invalid URLs it results in the empty
string.

Previously, systems used blink::protocolIsJavascript, which calls into 
url::FindAndCompareScheme. However, a StringView approach with the
already-canonicalized URL is good enough and more efficient, as it doesn't
scan for whitespace and can quickly fail with a length mismatch.

Also, callers were passing Strings around instead of KURLs, so this tightens 
the KURL interface.

BUG=348655

Review-Url: https://codereview.chromium.org/2644633006
Cr-Commit-Position: refs/heads/master@{#445481}
Committed:
https://chromium.googlesource.com/chromium/src/+/43d920ee6dea456674a0baa54506...
==========

[commit-bot: I haz the power, 2017-01-23 20:59:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43d920ee6dea456674a0baa54506...