third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 2644633006: Add KURL::protocolIsJavascript member function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2644633006: Add KURL::protocolIsJavascript member function (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index 5718ac82550f1d63e9b5574f9407988c554bf62c..ed05618b07ae7bac1f96455b39d745f2e253b58f 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -465,7 +465,7 @@ LayoutEmbeddedItem HTMLPlugInElement::layoutEmbeddedItem() const {

// depending on <param> values.

bool HTMLPlugInElement::allowedToLoadFrameURL(const String& url) {

KURL completeURL = document().completeURL(url);

- if (contentFrame() && protocolIsJavaScript(completeURL) &&

+ if (contentFrame() && completeURL.protocolIsJavaScript() &&

!document().getSecurityOrigin()->canAccess(

contentFrame()->securityContext()->getSecurityOrigin()))

return false;