Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2644613002: Revert of [iOS] Disable NSAssert and GTMDevAssert on release builds. (Closed)

Created:
3 years, 11 months ago by bzanotti
Modified:
3 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [iOS] Disable NSAssert and GTMDevAssert on release builds. (patchset #2 id:20001 of https://codereview.chromium.org/2637853002/ ) Reason for revert: This breaks things in downstream iOS as apparently EarlGrey requires NS_BLOCK_ASSERTIONS to not be defined and is built in Release (no idea why...) Original issue's description: > [iOS] Disable NSAssert and GTMDevAssert on release builds. > > This was present in build/common.gypi and was inadvertently dropped > during the conversion to GN (removed by http://crrev.com/2355673003, > but hadn't been added to GN). > > BUG=673253 > > Review-Url: https://codereview.chromium.org/2637853002 > Cr-Commit-Position: refs/heads/master@{#444355} > Committed: https://chromium.googlesource.com/chromium/src/+/32c54cffc1691c3b07501a86d72e75cebbf0e87f TBR=brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673253 Review-Url: https://codereview.chromium.org/2644613002 Cr-Commit-Position: refs/heads/master@{#444383} Committed: https://chromium.googlesource.com/chromium/src/+/0d55c8128e019ede3567bf5ea09af6312b9221c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bzanotti
Created Revert of [iOS] Disable NSAssert and GTMDevAssert on release builds.
3 years, 11 months ago (2017-01-18 16:18:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644613002/1
3 years, 11 months ago (2017-01-18 16:19:17 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 16:20:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0d55c8128e019ede3567bf5ea09a...

Powered by Google App Engine
This is Rietveld 408576698