DescriptionRevert of [iOS] Disable NSAssert and GTMDevAssert on release builds. (patchset #2 id:20001 of https://codereview.chromium.org/2637853002/ )
Reason for revert:
This breaks things in downstream iOS as apparently EarlGrey requires NS_BLOCK_ASSERTIONS to not be defined and is built in Release (no idea why...)
Original issue's description:
> [iOS] Disable NSAssert and GTMDevAssert on release builds.
>
> This was present in build/common.gypi and was inadvertently dropped
> during the conversion to GN (removed by http://crrev.com/2355673003,
> but hadn't been added to GN).
>
> BUG=673253
>
> Review-Url: https://codereview.chromium.org/2637853002
> Cr-Commit-Position: refs/heads/master@{#444355}
> Committed: https://chromium.googlesource.com/chromium/src/+/32c54cffc1691c3b07501a86d72e75cebbf0e87f
TBR=brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673253
Review-Url: https://codereview.chromium.org/2644613002
Cr-Commit-Position: refs/heads/master@{#444383}
Committed: https://chromium.googlesource.com/chromium/src/+/0d55c8128e019ede3567bf5ea09af6312b9221c1
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|