[iOS] Disable NSAssert and GTMDevAssert on release builds.

[iOS] Disable NSAssert and GTMDevAssert on release builds.

This was present in build/common.gypi and was inadvertently dropped
during the conversion to GN (removed by http://crrev.com/2355673003,
but hadn't been added to GN).

BUG=673253
Review-Url: https://codereview.chromium.org/2637853002
Cr-Commit-Position: refs/heads/master@{#444355}
Committed: https://chromium.googlesource.com/chromium/src/+/32c54cffc1691c3b07501a86d72e75cebbf0e87f

[bzanotti, 2017-01-16 14:36:28]

bzanotti@chromium.org changed reviewers:
+ brettw@chromium.org

[bzanotti, 2017-01-16 14:36:28]

Please take a look.

[brettw, 2017-01-17 20:51:51]

lgtm

https://codereview.chromium.org/2637853002/diff/1/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/2637853002/diff/1/build/config/BUILD.gn#newco...
build/config/BUILD.gn:226: defines += [ "NS_BLOCK_ASSERTIONS=1" ]
Can you add a comment here about what this does and why we want it? (i.e. not
"because the GYP build had it").

[bzanotti, 2017-01-18 14:01:24]

The CQ bit was checked by bzanotti@chromium.org

[bzanotti, 2017-01-18 14:01:24]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2637853002/#ps20001
(title: "Add comment explaining why asserts are disabled")

[bzanotti, 2017-01-18 14:01:27]

https://codereview.chromium.org/2637853002/diff/1/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/2637853002/diff/1/build/config/BUILD.gn#newco...
build/config/BUILD.gn:226: defines += [ "NS_BLOCK_ASSERTIONS=1" ]
On 2017/01/17 20:51:50, brettw (ping after 24h) wrote:
> Can you add a comment here about what this does and why we want it? (i.e. not
> "because the GYP build had it").

Done.

[commit-bot: I haz the power, 2017-01-18 14:01:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 14:59:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484748084364840,
"parent_rev": "5549f302eeb5cc43d3e13435c3826587721ddee8", "commit_rev":
"32c54cffc1691c3b07501a86d72e75cebbf0e87f"}

[commit-bot: I haz the power, 2017-01-18 15:00:04]

Description was changed from

==========
[iOS] Disable NSAssert and GTMDevAssert on release builds.

This was present in build/common.gypi and was inadvertently dropped
during the conversion to GN (removed by http://crrev.com/2355673003,
but hadn't been added to GN).

BUG=673253
==========

to

==========
[iOS] Disable NSAssert and GTMDevAssert on release builds.

This was present in build/common.gypi and was inadvertently dropped
during the conversion to GN (removed by http://crrev.com/2355673003,
but hadn't been added to GN).

BUG=673253

Review-Url: https://codereview.chromium.org/2637853002
Cr-Commit-Position: refs/heads/master@{#444355}
Committed:
https://chromium.googlesource.com/chromium/src/+/32c54cffc1691c3b07501a86d72e...
==========

[commit-bot: I haz the power, 2017-01-18 15:00:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/32c54cffc1691c3b07501a86d72e...

[bzanotti, 2017-01-18 16:18:55]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2644613002/ by bzanotti@chromium.org.

The reason for reverting is: This breaks things in downstream iOS as apparently
EarlGrey requires NS_BLOCK_ASSERTIONS to not be defined and is built in Release
(no idea why...).