Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2644603004: [wasm] Check for replacements of IndexNodes in the Int64Lowering. (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 11 months ago
Reviewers:
Eric Holk, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Check for replacements of IndexNodes in the Int64Lowering. The index input of load and store nodes has to be of type int32. However it is still possible that this index input was lowered by the Int64Lowering, for example if the index was a kTruncateInt64ToInt32 node. With this CL we check if there exists a replacement of the index and if so, use the replacement instead of the original index as the input for the lowered load and store nodes. BUG=v8:5874 R=titzer@chromium.org, eholk@chromium.org Review-Url: https://codereview.chromium.org/2644603004 Cr-Commit-Position: refs/heads/master@{#42559} Committed: https://chromium.googlesource.com/v8/v8/+/fba9047314fabf3f9cd1b68bf67158e544944348

Patch Set 1 #

Patch Set 2 : Remove unused variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/compiler/int64-lowering.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
ahaas
3 years, 11 months ago (2017-01-20 12:00:23 UTC) #1
titzer
lgtm
3 years, 11 months ago (2017-01-20 12:01:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644603004/20001
3 years, 11 months ago (2017-01-20 13:37:30 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 13:39:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fba9047314fabf3f9cd1b68bf67158e5449...

Powered by Google App Engine
This is Rietveld 408576698