Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2644543005: Element model support for covariant (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -70 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 6 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 7 chunks +67 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 18 chunks +53 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 4 chunks +14 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 5 chunks +137 lines, -2 lines 0 comments Download
M pkg/analyzer/test/dart/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 7 chunks +82 lines, -46 lines 2 comments Download
M pkg/analyzer/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
This doesn't get the remaining shared tests to pass. I'll look into doing that next. ...
3 years, 11 months ago (2017-01-19 22:51:18 UTC) #2
scheglov
lgtm https://codereview.chromium.org/2644543005/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart File pkg/analyzer/test/src/summary/resynthesize_common.dart (right): https://codereview.chromium.org/2644543005/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart#newcode933 pkg/analyzer/test/src/summary/resynthesize_common.dart:933: reason: '$desc isCovariant'); We already cast to Impl(s) ...
3 years, 11 months ago (2017-01-20 00:30:18 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2644543005/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart File pkg/analyzer/test/src/summary/resynthesize_common.dart (right): https://codereview.chromium.org/2644543005/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart#newcode933 pkg/analyzer/test/src/summary/resynthesize_common.dart:933: reason: '$desc isCovariant'); Ok. I moved the first test ...
3 years, 11 months ago (2017-01-20 15:59:07 UTC) #4
Brian Wilkerson
3 years, 11 months ago (2017-01-20 15:59:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
abeac7ea44f05d827dbe58c17aedc59d00b6d895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698