Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_ast.dart

Issue 2644543005: Element model support for covariant (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/summarize_ast.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_ast.dart b/pkg/analyzer/lib/src/summary/summarize_ast.dart
index 7eb3ad549b49e9e2fdc43a530e536be6212e7a77..6d885ef5021fca01fbb22d0629969c624234d084 100644
--- a/pkg/analyzer/lib/src/summary/summarize_ast.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_ast.dart
@@ -807,6 +807,7 @@ class _SummarizeAstVisitor extends RecursiveAstVisitor {
b.nameOffset = node.identifier.offset;
b.annotations = serializeAnnotations(node.metadata);
b.codeRange = serializeCodeRange(node);
+ b.isExplicitlyCovariant = node.covariantKeyword != null;
if (_parametersMayInheritCovariance) {
b.inheritsCovariantSlot = assignSlot();
}
@@ -971,10 +972,14 @@ class _SummarizeAstVisitor extends RecursiveAstVisitor {
Comment documentationComment,
NodeList<Annotation> annotations,
bool isField) {
+ bool isCovariant = isField
+ ? (variables.parent as FieldDeclaration).covariantKeyword != null
+ : false;
for (VariableDeclaration variable in variables.variables) {
UnlinkedVariableBuilder b = new UnlinkedVariableBuilder();
- b.isFinal = variables.isFinal;
b.isConst = variables.isConst;
+ b.isCovariant = isCovariant;
+ b.isFinal = variables.isFinal;
b.isStatic = isDeclaredStatic;
b.name = variable.name.name;
b.nameOffset = variable.name.offset;

Powered by Google App Engine
This is Rietveld 408576698