Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: pkg/analyzer/lib/src/dart/element/builder.dart

Issue 2644543005: Element model support for covariant (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/dart/element/builder.dart
diff --git a/pkg/analyzer/lib/src/dart/element/builder.dart b/pkg/analyzer/lib/src/dart/element/builder.dart
index 17af70d7db745f56734035563d8ed18633217a09..17f98e9db72f0de10a1941fe077b7067868af7ef 100644
--- a/pkg/analyzer/lib/src/dart/element/builder.dart
+++ b/pkg/analyzer/lib/src/dart/element/builder.dart
@@ -236,6 +236,7 @@ class ApiElementBuilder extends _BaseElementBuilder {
new FieldFormalParameterElementImpl.forNode(parameterName);
_setCodeRange(parameter, node);
parameter.isConst = node.isConst;
+ parameter.isExplicitlyCovariant = node.covariantKeyword != null;
parameter.isFinal = node.isFinal;
parameter.parameterKind = node.kind;
if (field != null) {
@@ -621,6 +622,7 @@ class ApiElementBuilder extends _BaseElementBuilder {
field = new FieldElementImpl.forNode(fieldName);
}
element = field;
+ field.isCovariant = fieldNode.covariantKeyword != null;
field.isStatic = fieldNode.isStatic;
_setCodeRange(element, node);
setElementDocumentationComment(element, fieldNode);
@@ -653,6 +655,10 @@ class ApiElementBuilder extends _BaseElementBuilder {
if (!isConst && !isFinal) {
PropertyAccessorElementImpl_ImplicitSetter setter =
new PropertyAccessorElementImpl_ImplicitSetter(element);
+ if (fieldNode != null) {
+ (setter.parameters[0] as ParameterElementImpl).isExplicitlyCovariant =
+ fieldNode.covariantKeyword != null;
+ }
_currentHolder.addAccessor(setter);
}
}
@@ -1389,6 +1395,7 @@ abstract class _BaseElementBuilder extends RecursiveAstVisitor<Object> {
}
_setCodeRange(parameter, node);
parameter.isConst = node.isConst;
+ parameter.isExplicitlyCovariant = node.parameter.covariantKeyword != null;
parameter.isFinal = node.isFinal;
parameter.parameterKind = node.kind;
// visible range
@@ -1410,6 +1417,9 @@ abstract class _BaseElementBuilder extends RecursiveAstVisitor<Object> {
ParameterElementImpl parameter =
new ParameterElementImpl.forNode(parameterName);
_setCodeRange(parameter, node);
+ parameter.isConst = node.isConst;
+ parameter.isExplicitlyCovariant = node.covariantKeyword != null;
+ parameter.isFinal = node.isFinal;
parameter.parameterKind = node.kind;
_setParameterVisibleRange(node, parameter);
_currentHolder.addParameter(parameter);
@@ -1437,6 +1447,7 @@ abstract class _BaseElementBuilder extends RecursiveAstVisitor<Object> {
new ParameterElementImpl.forNode(parameterName);
_setCodeRange(parameter, node);
parameter.isConst = node.isConst;
+ parameter.isExplicitlyCovariant = node.covariantKeyword != null;
parameter.isFinal = node.isFinal;
parameter.parameterKind = node.kind;
_setParameterVisibleRange(node, parameter);
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/dart/element/element.dart » ('j') | pkg/analyzer/test/src/summary/resynthesize_common.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698