Fix crash in CompressedTexSubImage taking 0 offset without pbo

Fix crash in CompressedTexSubImage taking 0 offset without pbo

DCHECK is triggered: "FATAL:gles2_implementation.cc(663)] Check failed:
data. " before this CL.

BUG=679678
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644483002
Cr-Commit-Position: refs/heads/master@{#444564}
Committed: https://chromium.googlesource.com/chromium/src/+/a5e49a2b2acf7ef4a79030c06589dde1e2ca3684

[qiankun, 2017-01-18 10:12:28]

Description was changed from

==========
Fix crash in CompressedTexSubImage taking 0 offset without pbo

DCHECK is triggered: "FATAL:gles2_implementation.cc(663)] Check failed:
data. " before this CL.

BUG=679678
==========

to

==========
Fix crash in CompressedTexSubImage taking 0 offset without pbo

DCHECK is triggered: "FATAL:gles2_implementation.cc(663)] Check failed:
data. " before this CL.

BUG=679678
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2017-01-18 10:12:29]

Description was changed from

==========
Fix crash in CompressedTexSubImage taking 0 offset without pbo

DCHECK is triggered: "FATAL:gles2_implementation.cc(663)] Check failed:
data. " before this CL.

BUG=679678
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix crash in CompressedTexSubImage taking 0 offset without pbo

DCHECK is triggered: "FATAL:gles2_implementation.cc(663)] Check failed:
data. " before this CL.

BUG=679678
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[qiankun, 2017-01-18 12:10:26]

qiankun.miao@intel.com changed reviewers:
+ kainino@chromium.org, kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2017-01-18 12:10:27]

This CL depends on the WebGL roll to make webgl-compressed-texture-etc.html
green: https://codereview.chromium.org/2642633002/. It rolled in
https://github.com/KhronosGroup/WebGL/pull/2265 which fixed the test when
WEBGL_compressed_texture_etc isn't available.

[Ken Russell (switch to Gerrit), 2017-01-18 21:56:42]

LGTM but Mo, could you review this too?

Qiankun, thanks for tracking this down.

[Zhenyao Mo, 2017-01-18 22:03:56]

The test is still failing on all platforms ...

[Ken Russell (switch to Gerrit), 2017-01-18 22:10:32]

On 2017/01/18 22:03:56, Zhenyao Mo wrote:
> The test is still failing on all platforms ...

I think this needs to be retried now that Qiankun's WebGL conformance roll has
landed.

[Zhenyao Mo, 2017-01-18 23:21:42]

On 2017/01/18 22:10:32, Ken Russell wrote:
> On 2017/01/18 22:03:56, Zhenyao Mo wrote:
> > The test is still failing on all platforms ...
> 
> I think this needs to be retried now that Qiankun's WebGL conformance roll has
> landed.

lgtm

[Zhenyao Mo, 2017-01-18 23:21:48]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2017-01-18 23:22:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:29:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484781708676650, "parent_rev":
"b288ced458b070ee2785301c4600d65806362557", "commit_rev":
"a5e49a2b2acf7ef4a79030c06589dde1e2ca3684"}

[commit-bot: I haz the power, 2017-01-19 00:30:02]

Description was changed from

==========
Fix crash in CompressedTexSubImage taking 0 offset without pbo

DCHECK is triggered: "FATAL:gles2_implementation.cc(663)] Check failed:
data. " before this CL.

BUG=679678
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Fix crash in CompressedTexSubImage taking 0 offset without pbo

DCHECK is triggered: "FATAL:gles2_implementation.cc(663)] Check failed:
data. " before this CL.

BUG=679678
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2644483002
Cr-Commit-Position: refs/heads/master@{#444564}
Committed:
https://chromium.googlesource.com/chromium/src/+/a5e49a2b2acf7ef4a79030c06589...
==========

[commit-bot: I haz the power, 2017-01-19 00:30:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a5e49a2b2acf7ef4a79030c06589...