Revert of [Sync] Make directory types registration explicit in ModelTypeRegistry

Revert of [Sync] Make directory types registration explicit in ModelTypeRegistry (patchset #3 id:40001 of https://codereview.chromium.org/2641523004/ )

Reason for revert:
This change causes crashes in sync: http://crbug.com/682998


Original issue's description:
> [Sync] Make directory types registration explicit in ModelTypeRegistry
> 
> The goal of this change is to make registration of directory types with
> ModelTypeRegistry to be driven by individual data type controllers. Today set of
> directory data types are registered with single call to
> SetEnabledDirectoryTypes, they are derived from routing info passed through
> sync manager and scheduler.
> 
> Since datatype registration will be performed as separate posts to sync thread
> it is important to switch scheduler to configuration mode at the beginning of
> configuration.
> 
> In this change I:
> - Added Register/UnregisterDirectoryType to ModelTypeConnector and
>   ModelTypeRegistry.
> - Removed SetEnabledDirectoryTypes form ModelTypeRegistry as it is no longer
>   needed.
> - Added StartConfiguration to SyncEngine. This method needs to be called before
>   RegisterDirectoryDataType are called so that normal sync cycle doesn't get
>   executed on sync thread and doesn't include new datatypes before their
>   services are ready to receive updates.
> - Added BeforeLoadModels method to DataTypeController. This method is called
>   right before LoadModels and allows directory datatypes to register with sync
>   engine before initial data downloading begins.
> 
> BUG=647505
> R=maxbogue@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2641523004
> Cr-Commit-Position: refs/heads/master@{#444846}
> Committed: https://chromium.googlesource.com/chromium/src/+/1c7af89ea2d8e6e5e31be9d1f7bfa6c306584f5d

TBR=maxbogue@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647505
Review-Url: https://codereview.chromium.org/2644373003
Cr-Commit-Position: refs/heads/master@{#445105}
Committed: https://chromium.googlesource.com/chromium/src/+/5c363ea4a04878fd491b6e674f802deff42245f6

[pavely, 2017-01-20 18:35:04]

The CQ bit was checked by pavely@chromium.org

[pavely, 2017-01-20 18:35:05]

Created Revert of [Sync] Make directory types registration explicit in
ModelTypeRegistry

[commit-bot: I haz the power, 2017-01-20 18:35:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 18:48:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484937304687230, "parent_rev":
"1882a0c07b4c4b1245d90ba3a083d93a577a1603", "commit_rev":
"5c363ea4a04878fd491b6e674f802deff42245f6"}

[commit-bot: I haz the power, 2017-01-20 18:49:37]

Description was changed from

==========
Revert of [Sync] Make directory types registration explicit in ModelTypeRegistry
(patchset #3 id:40001 of https://codereview.chromium.org/2641523004/ )

Reason for revert:
This change causes crashes in sync: http://crbug.com/682998


Original issue's description:
> [Sync] Make directory types registration explicit in ModelTypeRegistry
> 
> The goal of this change is to make registration of directory types with
> ModelTypeRegistry to be driven by individual data type controllers. Today set
of
> directory data types are registered with single call to
> SetEnabledDirectoryTypes, they are derived from routing info passed through
> sync manager and scheduler.
> 
> Since datatype registration will be performed as separate posts to sync thread
> it is important to switch scheduler to configuration mode at the beginning of
> configuration.
> 
> In this change I:
> - Added Register/UnregisterDirectoryType to ModelTypeConnector and
>   ModelTypeRegistry.
> - Removed SetEnabledDirectoryTypes form ModelTypeRegistry as it is no longer
>   needed.
> - Added StartConfiguration to SyncEngine. This method needs to be called
before
>   RegisterDirectoryDataType are called so that normal sync cycle doesn't get
>   executed on sync thread and doesn't include new datatypes before their
>   services are ready to receive updates.
> - Added BeforeLoadModels method to DataTypeController. This method is called
>   right before LoadModels and allows directory datatypes to register with sync
>   engine before initial data downloading begins.
> 
> BUG=647505
> R=maxbogue@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2641523004
> Cr-Commit-Position: refs/heads/master@{#444846}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1c7af89ea2d8e6e5e31be9d1f7bf...

TBR=maxbogue@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647505
==========

to

==========
Revert of [Sync] Make directory types registration explicit in ModelTypeRegistry
(patchset #3 id:40001 of https://codereview.chromium.org/2641523004/ )

Reason for revert:
This change causes crashes in sync: http://crbug.com/682998


Original issue's description:
> [Sync] Make directory types registration explicit in ModelTypeRegistry
> 
> The goal of this change is to make registration of directory types with
> ModelTypeRegistry to be driven by individual data type controllers. Today set
of
> directory data types are registered with single call to
> SetEnabledDirectoryTypes, they are derived from routing info passed through
> sync manager and scheduler.
> 
> Since datatype registration will be performed as separate posts to sync thread
> it is important to switch scheduler to configuration mode at the beginning of
> configuration.
> 
> In this change I:
> - Added Register/UnregisterDirectoryType to ModelTypeConnector and
>   ModelTypeRegistry.
> - Removed SetEnabledDirectoryTypes form ModelTypeRegistry as it is no longer
>   needed.
> - Added StartConfiguration to SyncEngine. This method needs to be called
before
>   RegisterDirectoryDataType are called so that normal sync cycle doesn't get
>   executed on sync thread and doesn't include new datatypes before their
>   services are ready to receive updates.
> - Added BeforeLoadModels method to DataTypeController. This method is called
>   right before LoadModels and allows directory datatypes to register with sync
>   engine before initial data downloading begins.
> 
> BUG=647505
> R=maxbogue@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2641523004
> Cr-Commit-Position: refs/heads/master@{#444846}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1c7af89ea2d8e6e5e31be9d1f7bf...

TBR=maxbogue@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=647505

Review-Url: https://codereview.chromium.org/2644373003
Cr-Commit-Position: refs/heads/master@{#445105}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c363ea4a04878fd491b6e674f80...
==========

[commit-bot: I haz the power, 2017-01-20 18:49:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c363ea4a04878fd491b6e674f80...