Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/sync/driver/directory_data_type_controller.cc

Issue 2644373003: Revert of [Sync] Make directory types registration explicit in ModelTypeRegistry (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/directory_data_type_controller.cc
diff --git a/components/sync/driver/directory_data_type_controller.cc b/components/sync/driver/directory_data_type_controller.cc
index 933a328ead72b01cf05911ed3830ab8201bb35f2..86fdd7350e1c831a3c25f2b59c8e989fed95226f 100644
--- a/components/sync/driver/directory_data_type_controller.cc
+++ b/components/sync/driver/directory_data_type_controller.cc
@@ -34,31 +34,6 @@
return false;
}
-void DirectoryDataTypeController::BeforeLoadModels(
- ModelTypeConfigurer* configurer) {
- configurer->RegisterDirectoryDataType(type(), model_safe_group_);
-}
-
-void DirectoryDataTypeController::RegisterWithBackend(
- base::Callback<void(bool)> set_downloaded,
- ModelTypeConfigurer* configurer) {}
-
-void DirectoryDataTypeController::ActivateDataType(
- ModelTypeConfigurer* configurer) {
- DCHECK(CalledOnValidThread());
- // Tell the backend about the change processor for this type so it can
- // begin routing changes to it.
- configurer->ActivateDirectoryDataType(type(), model_safe_group_,
- GetChangeProcessor());
-}
-
-void DirectoryDataTypeController::DeactivateDataType(
- ModelTypeConfigurer* configurer) {
- DCHECK(CalledOnValidThread());
- configurer->DeactivateDirectoryDataType(type());
- configurer->UnregisterDirectoryDataType(type());
-}
-
void DirectoryDataTypeController::GetAllNodes(
const AllNodesCallback& callback) {
std::unique_ptr<base::ListValue> node_list = GetAllNodesForTypeFromDirectory(
@@ -82,6 +57,25 @@
callback.Run(type(), counters);
}
+void DirectoryDataTypeController::RegisterWithBackend(
+ base::Callback<void(bool)> set_downloaded,
+ ModelTypeConfigurer* configurer) {}
+
+void DirectoryDataTypeController::ActivateDataType(
+ ModelTypeConfigurer* configurer) {
+ DCHECK(CalledOnValidThread());
+ // Tell the backend about the change processor for this type so it can
+ // begin routing changes to it.
+ configurer->ActivateDirectoryDataType(type(), model_safe_group_,
+ GetChangeProcessor());
+}
+
+void DirectoryDataTypeController::DeactivateDataType(
+ ModelTypeConfigurer* configurer) {
+ DCHECK(CalledOnValidThread());
+ configurer->DeactivateDirectoryDataType(type());
+}
+
// static
std::unique_ptr<base::ListValue>
DirectoryDataTypeController::GetAllNodesForTypeFromDirectory(
« no previous file with comments | « components/sync/driver/directory_data_type_controller.h ('k') | components/sync/driver/glue/sync_backend_host_core.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698