Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2644103005: Revert of Use Unthrottled instead of DOMManipulation in HTMLLinkElement/HTMLStyleElement (Closed)

Created:
3 years, 11 months ago by hiroshige
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Unthrottled instead of DOMManipulation in HTMLLinkElement/HTMLStyleElement (patchset #3 id:40001 of https://codereview.chromium.org/2596343002/ ) Reason for revert: This CL is not needed for M-57 and thus reverting before M-57 branch cut as planned. Original issue's description: > Use Unthrottled instead of DOMManipulation in HTMLLinkElement/HTMLStyleElement > > The async tasks for HTMLLinkElement/HTMLStyleElement::dispatchPendingEvent() > are on the critical paths to show popup windows for extensions, but > the DOMManipulation task runner is throttled because the tasks are executed > before the popup windows become visible, causing delay in showing popups. > > The scheduler is fixed by [1], but [1] is not merged to M-56. > This CL makes a mergeable workaround by using TaskType::Unthrottled for these > tasks to fix the issue on M-56. > > [1] https://codereview.chromium.org/2620743002 > > BUG=649942 > > Review-Url: https://codereview.chromium.org/2596343002 > Cr-Commit-Position: refs/heads/master@{#444559} > Committed: https://chromium.googlesource.com/chromium/src/+/812f90689e6637a5a4f13151dba661464716e29e TBR=haraken@chromium.org,alexclarke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=649942 Review-Url: https://codereview.chromium.org/2644103005 Cr-Commit-Position: refs/heads/master@{#444851} Committed: https://chromium.googlesource.com/chromium/src/+/1a7fcf622020ce0685a1a81a227d6b67650f8251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLStyleElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hiroshige
Created Revert of Use Unthrottled instead of DOMManipulation in HTMLLinkElement/HTMLStyleElement
3 years, 11 months ago (2017-01-19 21:48:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644103005/1
3 years, 11 months ago (2017-01-19 21:49:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1a7fcf622020ce0685a1a81a227d6b67650f8251
3 years, 11 months ago (2017-01-19 21:50:56 UTC) #6
haraken
3 years, 11 months ago (2017-01-20 00:08:19 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698