Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2596343002: Use Unthrottled instead of DOMManipulation in HTMLLinkElement/HTMLStyleElement (Closed)

Created:
4 years ago by hiroshige
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Unthrottled instead of DOMManipulation in HTMLLinkElement/HTMLStyleElement The async tasks for HTMLLinkElement/HTMLStyleElement::dispatchPendingEvent() are on the critical paths to show popup windows for extensions, but the DOMManipulation task runner is throttled because the tasks are executed before the popup windows become visible, causing delay in showing popups. The scheduler is fixed by [1], but [1] is not merged to M-56. This CL makes a mergeable workaround by using TaskType::Unthrottled for these tasks to fix the issue on M-56. [1] https://codereview.chromium.org/2620743002 BUG=649942 Review-Url: https://codereview.chromium.org/2596343002 Cr-Commit-Position: refs/heads/master@{#444559} Committed: https://chromium.googlesource.com/chromium/src/+/812f90689e6637a5a4f13151dba661464716e29e

Patch Set 1 #

Patch Set 2 : Also fixes StyleElement #

Patch Set 3 : Use Unthrottled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLStyleElement.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
hiroshige
PTAL. I locally tested this CL on Linux and the issue 649942 was fixed even ...
3 years, 11 months ago (2017-01-18 22:01:35 UTC) #12
haraken
LGTM
3 years, 11 months ago (2017-01-18 23:41:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596343002/40001
3 years, 11 months ago (2017-01-19 00:11:31 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/812f90689e6637a5a4f13151dba661464716e29e
3 years, 11 months ago (2017-01-19 00:17:17 UTC) #18
hiroshige
3 years, 11 months ago (2017-01-19 21:48:59 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2644103005/ by hiroshige@chromium.org.

The reason for reverting is: This CL is not needed for M-57 and thus
reverting before M-57 branch cut as planned.
.

Powered by Google App Engine
This is Rietveld 408576698