Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2643853006: Revert of Fix unused lambda captures in //device and //services/media_capture. (Closed)

Created:
3 years, 11 months ago by jianli
Modified:
3 years, 11 months ago
CC:
shalamov, chfremer+watch_chromium.org, chromium-reviews, mcasas+watch+vc_chromium.org, Mikhail, posciak+watch_chromium.org, wanming.lin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix unused lambda captures in //device and //services/media_capture. (patchset #1 id:1 of https://codereview.chromium.org/2649443002/ ) Reason for revert: https://build.chromium.org/p/chromium/builders/Win/builds/51061 Original issue's description: > Fix unused lambda captures in //device and //services/media_capture. > > Clang just got a new warning about unused lambda captures, > and that requires us to clean all places with this issue > across all the Chromium code base. This CL fixes all such > cases in //device and //services/media_capture. > > An example of a code that is no longer considered normal is > > auto g = [i, j]() { printf("%d\n", i); }; > > in which j is never used in the lambda and therefore its capture is unnecessary. > > BUG=681136 > > Review-Url: https://codereview.chromium.org/2649443002 > Cr-Commit-Position: refs/heads/master@{#444873} > Committed: https://chromium.googlesource.com/chromium/src/+/3cc294f047397929621de8cb19c2e911c8f488a1 TBR=rockot@chromium.org,krasin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=681136 Review-Url: https://codereview.chromium.org/2643853006 Cr-Commit-Position: refs/heads/master@{#444889} Committed: https://chromium.googlesource.com/chromium/src/+/7c9a1c6ec0f08e65ec3aa5e8a42a239c267ca611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/video_capture/test/fake_device_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jianli
Created Revert of Fix unused lambda captures in //device and //services/media_capture.
3 years, 11 months ago (2017-01-19 23:35:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643853006/1
3 years, 11 months ago (2017-01-19 23:35:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7c9a1c6ec0f08e65ec3aa5e8a42a239c267ca611
3 years, 11 months ago (2017-01-19 23:37:09 UTC) #6
krasin1
On 2017/01/19 23:37:09, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-19 23:51:14 UTC) #7
krasin1
3 years, 11 months ago (2017-01-19 23:51:49 UTC) #8
Message was sent while issue was closed.
On 2017/01/19 23:35:10, jianli wrote:
> Created Revert of Fix unused lambda captures in //device and
> //services/media_capture.

Thank you for reverting and sorry for the trouble. For some reason, no try bots
caught the issue.

Powered by Google App Engine
This is Rietveld 408576698