Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2649443002: Fix unused lambda captures in //device and //services/media_capture. (Closed)

Created:
3 years, 11 months ago by krasin1
Modified:
3 years, 11 months ago
CC:
shalamov, chfremer+watch_chromium.org, chromium-reviews, mcasas+watch+vc_chromium.org, Mikhail, posciak+watch_chromium.org, wanming.lin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unused lambda captures in //device and //services/media_capture. Clang just got a new warning about unused lambda captures, and that requires us to clean all places with this issue across all the Chromium code base. This CL fixes all such cases in //device and //services/media_capture. An example of a code that is no longer considered normal is auto g = [i, j]() { printf("%d\n", i); }; in which j is never used in the lambda and therefore its capture is unnecessary. BUG=681136 Review-Url: https://codereview.chromium.org/2649443002 Cr-Commit-Position: refs/heads/master@{#444873} Committed: https://chromium.googlesource.com/chromium/src/+/3cc294f047397929621de8cb19c2e911c8f488a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M services/video_capture/test/fake_device_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
krasin1
3 years, 11 months ago (2017-01-19 22:36:05 UTC) #2
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-19 22:41:09 UTC) #5
krasin1
On 2017/01/19 22:41:09, Ken Rockot wrote: > lgtm Thank you, Ken!
3 years, 11 months ago (2017-01-19 22:44:57 UTC) #6
krasin1
On 2017/01/19 22:41:09, Ken Rockot wrote: > lgtm Thank you, Ken!
3 years, 11 months ago (2017-01-19 22:44:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649443002/1
3 years, 11 months ago (2017-01-19 22:45:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3cc294f047397929621de8cb19c2e911c8f488a1
3 years, 11 months ago (2017-01-19 22:56:35 UTC) #13
jianli
3 years, 11 months ago (2017-01-19 23:35:10 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2643853006/ by jianli@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium/builders/Win/builds/51061.

Powered by Google App Engine
This is Rietveld 408576698