Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2643723009: Revert of Remove obsolete code that invalidates document element on LayoutView resize (patchset #3 … (Closed)

Created:
3 years, 11 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
chrishtr, trchen
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, mac-reviews_chromium.org, blink-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert of Remove obsolete code that invalidates document element on LayoutView resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ ) Reason for revert: Caused bug 680745. Revert first and then work on the correct fix. Original issue's description: > Remove obsolete code that invalidates document element on LayoutView resize > > The code was needed when the document element painted viewport > background. Now ViewPainter paint viewport background, and we invalidate > LayoutView itself on its resize. > > BUG=475115 > > Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4 > Cr-Commit-Position: refs/heads/master@{#430097} TBR=chrishtr@chromium.org,trchen@chromium.org BUG=680745 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2643723009 Cr-Commit-Position: refs/branch-heads/2924@{#819} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/0a83d3c6e6fcee35ef35f57164fc446e88014034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+606 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/border-radius-repaint-2-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-and-absolute-position-scrolled-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/scrolled-iframe-scrollbar-change-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-composited-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-generated-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-non-fixed-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-media-query-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-width-height-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-bottom-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-percent-top-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-viewport-percent-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-2-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-8-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-shrink-row-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/text-match-document-change-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 8 chunks +42 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-shrink-row-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/text-match-document-change-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 8 chunks +42 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-shrink-row-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/text-match-document-change-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 8 chunks +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643723009/1
3 years, 11 months ago (2017-01-20 18:33:54 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 11 months ago (2017-01-20 18:33:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643723009/1
3 years, 11 months ago (2017-01-20 18:36:15 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 18:41:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a83d3c6e6fcee35ef35f57164fc...

Powered by Google App Engine
This is Rietveld 408576698