CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 11 months ago
(2017-01-20 18:33:56 UTC)
#4
CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them
Xianzhu
Description was changed from ========== Revert of Remove obsolete code that invalidates document element on ...
3 years, 11 months ago
(2017-01-20 18:35:22 UTC)
#5
Description was changed from
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
BUG=680745
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=475115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOTRY=true
NOPRESUMBIT=true
Review-Url: https://codereview.chromium.org/2634613002
Cr-Commit-Position: refs/heads/master@{#443764}
==========
to
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=680745
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOTRY=true
NOPRESUMBIT=true
==========
Xianzhu
Description was changed from ========== Revert of Remove obsolete code that invalidates document element on ...
3 years, 11 months ago
(2017-01-20 18:35:38 UTC)
#6
Description was changed from
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=680745
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOTRY=true
NOPRESUMBIT=true
==========
to
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=680745
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOTRY=true
NOPRESUBMIT=true
==========
Xianzhu
Description was changed from ========== Revert of Remove obsolete code that invalidates document element on ...
3 years, 11 months ago
(2017-01-20 18:35:56 UTC)
#7
Description was changed from
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=680745
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
NOTRY=true
NOPRESUBMIT=true
==========
to
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=680745
NOTRY=true
NOPRESUBMIT=true
==========
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
3 years, 11 months ago
(2017-01-20 18:36:01 UTC)
#8
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1484937361324190, "parent_rev": "4c7e0db8fdd332bda882e134f8f58b73a7a6f0aa", "commit_rev": "0a83d3c6e6fcee35ef35f57164fc446e88014034"}
3 years, 11 months ago
(2017-01-20 18:41:25 UTC)
#10
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484937361324190, "parent_rev":
"4c7e0db8fdd332bda882e134f8f58b73a7a6f0aa", "commit_rev":
"0a83d3c6e6fcee35ef35f57164fc446e88014034"}
commit-bot: I haz the power
Description was changed from ========== Revert of Remove obsolete code that invalidates document element on ...
3 years, 11 months ago
(2017-01-20 18:41:55 UTC)
#11
Message was sent while issue was closed.
Description was changed from
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=680745
NOTRY=true
NOPRESUBMIT=true
==========
to
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=680745
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2643723009
Cr-Commit-Position: refs/branch-heads/2924@{#819}
Cr-Branched-From:
3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a83d3c6e6fcee35ef35f57164fc...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0a83d3c6e6fcee35ef35f57164fc446e88014034
3 years, 11 months ago
(2017-01-20 18:41:56 UTC)
#12
Issue 2643723009: Revert of Remove obsolete code that invalidates document element on LayoutView resize (patchset #3 …
(Closed)
Created 3 years, 11 months ago by Xianzhu
Modified 3 years, 11 months ago
Reviewers: chrishtr, trchen
Base URL:
Comments: 0