Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2634613002: Revert of Remove obsolete code that invalidates document element on LayoutView resize (Closed)

Created:
3 years, 11 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
chrishtr, trchen
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove obsolete code that invalidates document element on LayoutView resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ ) Reason for revert: Caused bug 680745. Revert first and then work on the correct fix. BUG=680745 Original issue's description: > Remove obsolete code that invalidates document element on LayoutView resize > > The code was needed when the document element painted viewport > background. Now ViewPainter paint viewport background, and we invalidate > LayoutView itself on its resize. > > BUG=475115 > > Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4 > Cr-Commit-Position: refs/heads/master@{#430097} TBR=chrishtr@chromium.org,trchen@chromium.org BUG=475115 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2634613002 Cr-Commit-Position: refs/heads/master@{#443764} Committed: https://chromium.googlesource.com/chromium/src/+/d25330043a055c1327f5abec3fc512376531cc93

Patch Set 1 #

Patch Set 2 : Resolve conflicts #

Patch Set 3 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+707 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/border-radius-repaint-2-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-and-absolute-position-scrolled-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/scrolled-iframe-scrollbar-change-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 1 4 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-composited-expected.txt View 1 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-fixed-centered-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-generated-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-background-image-non-fixed-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt View 1 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-media-query-expected.txt View 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-html-expected.txt View 1 8 chunks +36 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-percent-width-height-expected.txt View 1 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-bottom-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-positioned-percent-top-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-viewport-percent-expected.txt View 4 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt View 1 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-2-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/line-flow-with-floats-8-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-addition-expected.txt View 1 4 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/shift-relative-positioned-container-with-image-removal-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table-shrink-row-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/text-match-document-change-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 1 8 chunks +42 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt View 1 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table-shrink-row-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/text-match-document-change-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 1 8 chunks +42 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/abspos-shift-image-incorrect-repaint-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt View 1 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table-shrink-row-repaint-expected.txt View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/text-match-document-change-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 1 8 chunks +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 2 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp View 1 2 4 chunks +23 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Xianzhu
Created Revert of Remove obsolete code that invalidates document element on LayoutView resize
3 years, 11 months ago (2017-01-13 20:32:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634613002/1
3 years, 11 months ago (2017-01-13 20:33:43 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/135796) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-13 20:37:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634613002/290001
3 years, 11 months ago (2017-01-13 23:51:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634613002/310001
3 years, 11 months ago (2017-01-13 23:55:23 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 01:43:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:310001) as
https://chromium.googlesource.com/chromium/src/+/d25330043a055c1327f5abec3fc5...

Powered by Google App Engine
This is Rietveld 408576698