Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/135796) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago
(2017-01-13 20:37:26 UTC)
#5
Description was changed from ========== Revert of Remove obsolete code that invalidates document element on ...
3 years, 11 months ago
(2017-01-13 20:40:02 UTC)
#6
Description was changed from
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
BUG=680745
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=475115
==========
to
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
BUG=680745
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=475115
==========
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
3 years, 11 months ago
(2017-01-13 23:51:05 UTC)
#7
Description was changed from ========== Revert of Remove obsolete code that invalidates document element on ...
3 years, 11 months ago
(2017-01-13 23:55:11 UTC)
#9
Description was changed from
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
BUG=680745
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=475115
==========
to
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
BUG=680745
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=475115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
3 years, 11 months ago
(2017-01-13 23:55:16 UTC)
#10
CQ is committing da patch. Bot data: {"patchset_id": 310001, "attempt_start_ts": 1484351716081240, "parent_rev": "db3849840dea3dae2de134d875423ad05aa27f78", "commit_rev": "d25330043a055c1327f5abec3fc512376531cc93"}
3 years, 11 months ago
(2017-01-14 01:42:45 UTC)
#12
CQ is committing da patch.
Bot data: {"patchset_id": 310001, "attempt_start_ts": 1484351716081240,
"parent_rev": "db3849840dea3dae2de134d875423ad05aa27f78", "commit_rev":
"d25330043a055c1327f5abec3fc512376531cc93"}
commit-bot: I haz the power
Description was changed from ========== Revert of Remove obsolete code that invalidates document element on ...
3 years, 11 months ago
(2017-01-14 01:43:23 UTC)
#13
Message was sent while issue was closed.
Description was changed from
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
BUG=680745
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=475115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
to
==========
Revert of Remove obsolete code that invalidates document element on LayoutView
resize (patchset #3 id:40001 of https://codereview.chromium.org/2483483003/ )
Reason for revert:
Caused bug 680745. Revert first and then work on the correct fix.
BUG=680745
Original issue's description:
> Remove obsolete code that invalidates document element on LayoutView resize
>
> The code was needed when the document element painted viewport
> background. Now ViewPainter paint viewport background, and we invalidate
> LayoutView itself on its resize.
>
> BUG=475115
>
> Committed: https://crrev.com/1bddf0ae1615f5c67ca034d7e08dfdb1ea5846c4
> Cr-Commit-Position: refs/heads/master@{#430097}
TBR=chrishtr@chromium.org,trchen@chromium.org
BUG=475115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2634613002
Cr-Commit-Position: refs/heads/master@{#443764}
Committed:
https://chromium.googlesource.com/chromium/src/+/d25330043a055c1327f5abec3fc5...
==========
commit-bot: I haz the power
Committed patchset #3 (id:310001) as https://chromium.googlesource.com/chromium/src/+/d25330043a055c1327f5abec3fc512376531cc93
3 years, 11 months ago
(2017-01-14 01:43:24 UTC)
#14
Issue 2634613002: Revert of Remove obsolete code that invalidates document element on LayoutView resize
(Closed)
Created 3 years, 11 months ago by Xianzhu
Modified 3 years, 11 months ago
Reviewers: chrishtr, trchen
Base URL:
Comments: 0