third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html - Issue 2643723003: Media Controls: do not handle any event if no controls should be visible.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-no-controls-events-not-absorbed.html

Issue 2643723003: Media Controls: do not handle any event if no controls should be visible. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Video elements without controls should not absborb click events</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-file.js"></script>

	6 <video></video>

	7 <script>

	8 test(_ => {
	whywhat 2017/01/18 19:37:17 nit: blank line before? nit: blank line before?
	9 assert_true('eventSender' in window);

	10 }, 'eventSender required');

	11

	12 async_test(t => {

	13 var video = document.querySelector('video');

	14 video.addEventListener('loadedmetadata', t.step_func(_ => {
	whywhat 2017/01/18 19:37:17 won't this fail on low-end devices? won't this fail on low-end devices? mlamouri (slow - plz ping) 2017/01/19 10:51:00 I think most of the media/ tests wouldn't work on Show quoted text On 2017/01/18 at 19:37:17, whywhat wrote: > won't this fail on low-end devices? I think most of the media/ tests wouldn't work on low end devices because they rely on the loading happening without a gesture :)
	15 var rect = video.getBoundingClientRect();

	16 eventSender.gestureTap(rect.left + rect.width / 2,

	17 rect.top + rect.height / 2);

	18 }));

	19

	20 addEventListener('click', t.step_func(_ => {

	21 assert_true(true, 'Received click');

	22 t.done();

	23 }));

	24

	25 video.src = findMediaFile('video', 'content/test');

	26 });

	27 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »