Fix language/bad_constructor_test in dartk and analyzer.

Fix language/bad_constructor_test in dartk and analyzer.

The test was incorrect because it did not declare that a static warning
was to be expected due to an unresolved reference to 'q'. The unresolved
reference has been removed as it has nothing to do with what it is
supposed to test.

The analyzer was incorrect in that a setter was reported to clash with
a constructor of the same name, but this failure was hidden by the
above issue. This has been fixed.

dartk inherited the issue (and its fix) from the analyzer, but some
additional error handling was needed in dartk to avoid crashing.

Closes https://github.com/dart-lang/sdk/issues/11576

BUG=
R=kmillikin@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/76442f93947e41a85ed7242a7366cf114d680a8a

[asgerf, 2017-01-18 09:52:39]

Description was changed from

==========
Fix language/bad_constructor_test in dartk and analyzer.

The test was incorrect because it did not declare that a static warning
was to be expected due to an unresolved reference to 'q'. The unresolved
reference has been removed as it has nothing to do with what it is
supposed to test.

The analyzer was incorrect in that a setter was reported to clash with
a constructor of the same name, but this failure was hidden by the
above issue. This has been fixed.

dartk inherited the issue from the analyzer, but some additional error
handling was needed in dartk to avoid crashing.

Closes 11576

BUG=
==========

to

==========
Fix language/bad_constructor_test in dartk and analyzer.

The test was incorrect because it did not declare that a static warning
was to be expected due to an unresolved reference to 'q'. The unresolved
reference has been removed as it has nothing to do with what it is
supposed to test.

The analyzer was incorrect in that a setter was reported to clash with
a constructor of the same name, but this failure was hidden by the
above issue. This has been fixed.

dartk inherited the issue from the analyzer, but some additional error
handling was needed in dartk to avoid crashing.

Closes https://github.com/dart-lang/sdk/issues/11576

BUG=
==========

[asgerf, 2017-01-18 09:53:45]

Description was changed from

==========
Fix language/bad_constructor_test in dartk and analyzer.

The test was incorrect because it did not declare that a static warning
was to be expected due to an unresolved reference to 'q'. The unresolved
reference has been removed as it has nothing to do with what it is
supposed to test.

The analyzer was incorrect in that a setter was reported to clash with
a constructor of the same name, but this failure was hidden by the
above issue. This has been fixed.

dartk inherited the issue from the analyzer, but some additional error
handling was needed in dartk to avoid crashing.

Closes https://github.com/dart-lang/sdk/issues/11576

BUG=
==========

to

==========
Fix language/bad_constructor_test in dartk and analyzer.

The test was incorrect because it did not declare that a static warning
was to be expected due to an unresolved reference to 'q'. The unresolved
reference has been removed as it has nothing to do with what it is
supposed to test.

The analyzer was incorrect in that a setter was reported to clash with
a constructor of the same name, but this failure was hidden by the
above issue. This has been fixed.

dartk inherited the issue (and its fix) from the analyzer, but some
additional error handling was needed in dartk to avoid crashing.

Closes https://github.com/dart-lang/sdk/issues/11576

BUG=
==========

[asgerf, 2017-01-18 10:04:00]

asgerf@google.com changed reviewers:
+ kmillikin@google.com, scheglov@google.com

[Kevin Millikin (Google), 2017-01-18 10:39:19]

LGTM.

[scheglov, 2017-01-18 17:11:52]

lgtm

https://codereview.chromium.org/2643693002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2643693002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:2710: if (field != null &&
field.getter != null) {
Could you add a couple of unit tests to analyzer?

To non_error_resolver_test.dart/NonErrorResolverTest:

  test_conflictingConstructorNameAndMember_setter() async {
    Source source = addSource(r'''
class A {
  A.x() {}
  set x(_) {}
}''');
    await computeAnalysisResult(source);
    assertNoErrors(source);
    verify([source]);
  }


To compile_time_error_code_test.dart/CompileTimeErrorCodeTest:

  test_conflictingConstructorNameAndMember_getter() async {
    Source source = addSource(r'''
class A {
  int get x => 42;
  A.x() {}
}''');
    await computeAnalysisResult(source);
    assertErrors(
        source, [CompileTimeErrorCode.CONFLICTING_CONSTRUCTOR_NAME_AND_FIELD]);
    verify([source]);
  }

[asgerf, 2017-01-18 18:18:34]

https://codereview.chromium.org/2643693002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2643693002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:2710: if (field != null &&
field.getter != null) {
On 2017/01/18 17:11:52, scheglov wrote:
> Could you add a couple of unit tests to analyzer?
> 
> To non_error_resolver_test.dart/NonErrorResolverTest:
> 
>   test_conflictingConstructorNameAndMember_setter() async {
>     Source source = addSource(r'''
> class A {
>   A.x() {}
>   set x(_) {}
> }''');
>     await computeAnalysisResult(source);
>     assertNoErrors(source);
>     verify([source]);
>   }
> 
> 
> To compile_time_error_code_test.dart/CompileTimeErrorCodeTest:
> 
>   test_conflictingConstructorNameAndMember_getter() async {
>     Source source = addSource(r'''
> class A {
>   int get x => 42;
>   A.x() {}
> }''');
>     await computeAnalysisResult(source);
>     assertErrors(
>         source,
[CompileTimeErrorCode.CONFLICTING_CONSTRUCTOR_NAME_AND_FIELD]);
>     verify([source]);
>   }

Absolutely! Thanks for writing them.

[asgerf, 2017-01-19 12:10:39]

Description was changed from

==========
Fix language/bad_constructor_test in dartk and analyzer.

The test was incorrect because it did not declare that a static warning
was to be expected due to an unresolved reference to 'q'. The unresolved
reference has been removed as it has nothing to do with what it is
supposed to test.

The analyzer was incorrect in that a setter was reported to clash with
a constructor of the same name, but this failure was hidden by the
above issue. This has been fixed.

dartk inherited the issue (and its fix) from the analyzer, but some
additional error handling was needed in dartk to avoid crashing.

Closes https://github.com/dart-lang/sdk/issues/11576

BUG=
==========

to

==========
Fix language/bad_constructor_test in dartk and analyzer.

The test was incorrect because it did not declare that a static warning
was to be expected due to an unresolved reference to 'q'. The unresolved
reference has been removed as it has nothing to do with what it is
supposed to test.

The analyzer was incorrect in that a setter was reported to clash with
a constructor of the same name, but this failure was hidden by the
above issue. This has been fixed.

dartk inherited the issue (and its fix) from the analyzer, but some
additional error handling was needed in dartk to avoid crashing.

Closes https://github.com/dart-lang/sdk/issues/11576

BUG=
R=kmillikin@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/76442f93947e41a85ed7242a7366cf114d680a8a
==========

[asgerf, 2017-01-19 12:10:40]

Committed patchset #4 (id:60001) manually as
76442f93947e41a85ed7242a7366cf114d680a8a (presubmit successful).