Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: pkg/kernel/lib/analyzer/ast_from_analyzer.dart

Issue 2643693002: Fix language/bad_constructor_test in dartk and analyzer. (Closed)
Patch Set: Remove extra blank line Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/non_error_resolver_test.dart ('k') | tests/language/bad_constructor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/analyzer/ast_from_analyzer.dart
diff --git a/pkg/kernel/lib/analyzer/ast_from_analyzer.dart b/pkg/kernel/lib/analyzer/ast_from_analyzer.dart
index cbbf53ea29593bb3c3d1d3e6e6373d64d072a1db..f6830de82b6b9af0fae0bc46f96a2957fe3d1226 100644
--- a/pkg/kernel/lib/analyzer/ast_from_analyzer.dart
+++ b/pkg/kernel/lib/analyzer/ast_from_analyzer.dart
@@ -2738,6 +2738,10 @@ class MemberBodyBuilder extends GeneralizingAstVisitor<Null> {
}
void buildGenerativeConstructor(ConstructorDeclaration node) {
+ if (currentMember is! ast.Constructor) {
+ buildBrokenMember();
+ return;
+ }
addAnnotations(node.metadata);
ast.Constructor constructor = currentMember;
constructor.function = scope.buildFunctionNode(node.parameters, node.body,
@@ -2790,6 +2794,10 @@ class MemberBodyBuilder extends GeneralizingAstVisitor<Null> {
}
void buildFactoryConstructor(ConstructorDeclaration node) {
+ if (currentMember is! ast.Procedure) {
+ buildBrokenMember();
+ return;
+ }
addAnnotations(node.metadata);
ast.Procedure procedure = currentMember;
ClassElement classElement = resolutionMap
« no previous file with comments | « pkg/analyzer/test/generated/non_error_resolver_test.dart ('k') | tests/language/bad_constructor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698