Fix language/bad_constructor_test in dartk and analyzer.

pkg/analyzer/lib/src/generated/error_verifier.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.error_verifier;
 
 import 'dart:collection';
 import "dart:math" as math;
 
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 2688 matching lines @@
               constructor,
               [name]);
         }
         return;
       }
     }
     // conflict with class member
     if (constructorName != null &&
         constructorElement != null &&
         !constructorName.isSynthetic) {
-      if (classElement.getField(name) != null) {
-        // fields
+      FieldElement field = classElement.getField(name);
+      if (field != null && field.getter != null) {

[scheglov, 2017/01/18 17:11:52]

Could you add a couple of unit tests to analyzer?

To non_error_resolver_test.dart/NonErrorResolverTest:

  test_conflictingConstructorNameAndMember_setter() async {
    Source source = addSource(r'''
class A {
  A.x() {}
  set x(_) {}
}''');
    await computeAnalysisResult(source);
    assertNoErrors(source);
    verify([source]);
  }


To compile_time_error_code_test.dart/CompileTimeErrorCodeTest:

  test_conflictingConstructorNameAndMember_getter() async {
    Source source = addSource(r'''
class A {
  int get x => 42;
  A.x() {}
}''');
    await computeAnalysisResult(source);
    assertErrors(
        source, [CompileTimeErrorCode.CONFLICTING_CONSTRUCTOR_NAME_AND_FIELD]);
    verify([source]);
  }

[asgerf, 2017/01/18 18:18:34]

Absolutely! Thanks for writing them.

         _errorReporter.reportErrorForNode(
             CompileTimeErrorCode.CONFLICTING_CONSTRUCTOR_NAME_AND_FIELD,
             constructor,
             [name]);
       } else if (classElement.getMethod(name) != null) {
         // methods
         _errorReporter.reportErrorForNode(
             CompileTimeErrorCode.CONFLICTING_CONSTRUCTOR_NAME_AND_METHOD,
             constructor,
             [name]);
@@ skipping 4285 matching lines @@
 class _InvocationCollector extends RecursiveAstVisitor {
   final List<String> superCalls = <String>[];
 
   @override
   visitMethodInvocation(MethodInvocation node) {
     if (node.target is SuperExpression) {
       superCalls.add(node.methodName.name);
     }
   }
 }