Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2643643003: Remove unused and obsolete Tab -currentRedirectedURLs method. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused and obsolete Tab -currentRedirectedURLs method. This method is never called, so remove it from Tab and from CRWSessionController. BUG=454984, 681867 Review-Url: https://codereview.chromium.org/2643643003 Cr-Commit-Position: refs/heads/master@{#444387} Committed: https://chromium.googlesource.com/chromium/src/+/fc6093128799d18b1b27d7dbf7f07e64df524602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M ios/chrome/browser/tabs/tab.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/web/navigation/crw_session_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 chunk +0 lines, -30 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 11 months ago (2017-01-18 14:08:11 UTC) #4
rohitrao (ping after 24h)
lgtm 6 lines down, 2372 to go.
3 years, 11 months ago (2017-01-18 15:35:06 UTC) #7
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-18 16:23:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643643003/1
3 years, 11 months ago (2017-01-18 16:24:21 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 16:29:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc6093128799d18b1b27d7dbf7f0...

Powered by Google App Engine
This is Rietveld 408576698