MD History: Use one-way binding for history query state.

MD History: Use one-way binding for history query state.

Instead of changing query state anywhere within the history code,
elements now fire an event containing the changes they want to make.
This is picked up by the query-manager and used to modify the page state
as needed. Any UI changes will then flow down through the page using
one-way binding.

This pattern further centralises the querying logic, decoupling it from
the UI state. It also adds the capability to make multiple changes to
the query state at once, which is necessary to support routing for
Grouped History.

BUG=675841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2643533003
Cr-Commit-Position: refs/heads/master@{#445526}
Committed: https://chromium.googlesource.com/chromium/src/+/b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222

[tsergeant, 2017-01-18 04:30:42]

Description was changed from

==========
MD History: Use one-way binding for history query state.

WIP WIP WIP

BUG=
==========

to

==========
MD History: Use one-way binding for history query state.

WIP WIP WIP

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-01-18 06:04:32]

Description was changed from

==========
MD History: Use one-way binding for history query state.

WIP WIP WIP

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Use one-way binding for history query state.

Instead of changing query state anywhere within the history code,
elements now fire an event containing the changes they want to make.
This is picked up by the query-manager and used to modify the page state
as needed. Any UI changes will then flow down through the page using
one-way binding.

This pattern further centralises the querying logic, decoupling it from
the UI state. It also adds the capability to make multiple changes to
the query state at once, which is necessary to support routing for
Grouped History.

BUG=675841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-01-18 06:04:38]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 06:04:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-01-18 06:21:12]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 06:21:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-01-18 06:22:15]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-01-18 06:22:15]

Part two!

[commit-bot: I haz the power, 2017-01-18 07:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 07:17:55]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-23 02:31:14]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 02:31:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-01-23 03:03:56]

I am a fan of this CL.

lgtm.

https://codereview.chromium.org/2643533003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.js (right):

https://codereview.chromium.org/2643533003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.js:159: 'change-query',
{range: Number(e.detail.item.getAttribute('value'))});
FYI the setter for the grouped range already makes a number out of this. I don't
mind leaving this here either way.

https://codereview.chromium.org/2643533003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/query_manager.js (right):

https://codereview.chromium.org/2643533003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/query_manager.js:102: changeQuery_:
function(changes) {
Why not just put this all in onChangeQuery?

[commit-bot: I haz the power, 2017-01-23 03:32:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 03:32:32]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-23 04:18:27]

https://codereview.chromium.org/2643533003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.js (right):

https://codereview.chromium.org/2643533003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.js:159: 'change-query',
{range: Number(e.detail.item.getAttribute('value'))});
On 2017/01/23 03:03:56, calamity wrote:
> FYI the setter for the grouped range already makes a number out of this. I
don't
> mind leaving this here either way.

Gonna leave it here to be extra sure -- I was noticing in devtools that the old
system didn't actually convert to a number all the time.

Plus, this way the types are correct in changeQuery_ before it even hits
queryState.

https://codereview.chromium.org/2643533003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/query_manager.js (right):

https://codereview.chromium.org/2643533003/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/query_manager.js:102: changeQuery_:
function(changes) {
On 2017/01/23 03:03:56, calamity wrote:
> Why not just put this all in onChangeQuery?

This is a relic from when all this code was in router, and it was desirable to
be able to call into this method directly.

Nowadays it could be pulled into the event listener, except that I cannot figure
out how to get closure to accept a custom type for `e.detail` while still seeing
`e` as an Event.

/shruggie

Happy to show you in person to see if we can puzzle it out.

[tsergeant, 2017-01-23 05:02:46]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-01-23 05:02:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2643533003/#ps60001
(title: "Remove wrapper function")

[commit-bot: I haz the power, 2017-01-23 05:02:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 06:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 06:46:06]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2017-01-23 21:40:53]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-01-23 21:41:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 22:56:31]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485207653360970,
"parent_rev": "eff9252e95930e904f389f7f902bd9c815243f82", "commit_rev":
"b82ab87dd4f38c3c7ca5d6d2e8e3a96220772222"}

[commit-bot: I haz the power, 2017-01-23 22:56:58]

Description was changed from

==========
MD History: Use one-way binding for history query state.

Instead of changing query state anywhere within the history code,
elements now fire an event containing the changes they want to make.
This is picked up by the query-manager and used to modify the page state
as needed. Any UI changes will then flow down through the page using
one-way binding.

This pattern further centralises the querying logic, decoupling it from
the UI state. It also adds the capability to make multiple changes to
the query state at once, which is necessary to support routing for
Grouped History.

BUG=675841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Use one-way binding for history query state.

Instead of changing query state anywhere within the history code,
elements now fire an event containing the changes they want to make.
This is picked up by the query-manager and used to modify the page state
as needed. Any UI changes will then flow down through the page using
one-way binding.

This pattern further centralises the querying logic, decoupling it from
the UI state. It also adds the capability to make multiple changes to
the query state at once, which is necessary to support routing for
Grouped History.

BUG=675841
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2643533003
Cr-Commit-Position: refs/heads/master@{#445526}
Committed:
https://chromium.googlesource.com/chromium/src/+/b82ab87dd4f38c3c7ca5d6d2e8e3...
==========

[commit-bot: I haz the power, 2017-01-23 22:56:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b82ab87dd4f38c3c7ca5d6d2e8e3...